From 5f1c820afb2afe30abc16f5c99432f6707defc67 Mon Sep 17 00:00:00 2001 From: Patrick Mullen Date: Wed, 5 Feb 2025 15:57:36 -0500 Subject: [PATCH 1/3] Start updating to v4 artifacts --- .github/workflows/ci-extended.yml | 4 ++-- .github/workflows/ci-macos.yml | 2 +- .github/workflows/ci-short.yml | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-extended.yml b/.github/workflows/ci-extended.yml index 1dd39c782477..c673aeb6dd60 100644 --- a/.github/workflows/ci-extended.yml +++ b/.github/workflows/ci-extended.yml @@ -115,7 +115,7 @@ jobs: exit 1 fi - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: log-and-convergence-${{ matrix.device }}-${{ matrix.parallel }} path: | @@ -173,7 +173,7 @@ jobs: cd build ctest -L regression -L ${{ matrix.parallel }} -LE perf-reg --timeout 3600 - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: log-and-convergence-${{ matrix.parallel }} path: | diff --git a/.github/workflows/ci-macos.yml b/.github/workflows/ci-macos.yml index a1666b5a9520..17130d046cee 100644 --- a/.github/workflows/ci-macos.yml +++ b/.github/workflows/ci-macos.yml @@ -43,7 +43,7 @@ jobs: cd build ctest -LE mpi - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: configure-log-unit-macos path: build/CMakeFiles/CMakeOutput.log diff --git a/.github/workflows/ci-short.yml b/.github/workflows/ci-short.yml index 7e0fd8bf759a..84dc1f92a7de 100644 --- a/.github/workflows/ci-short.yml +++ b/.github/workflows/ci-short.yml @@ -67,7 +67,7 @@ jobs: # Pick GPU with most available memory export CUDA_VISIBLE_DEVICES=$(nvidia-smi --query-gpu=memory.free,index --format=csv,nounits,noheader | sort -nr | head -1 | awk '{ print $NF }') ctest -LE 'performance|regression' - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: configure-log-unit-${{ matrix.device }} path: build/CMakeFiles/CMakeOutput.log @@ -126,7 +126,7 @@ jobs: if grep HtoD profile.txt; then exit 1; fi if grep DtoH profile.txt; then exit 1; fi - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: configure-log-integration-${{ matrix.device }} path: | @@ -168,7 +168,7 @@ jobs: cd build ctest -R regression_mpi_test:particle_leapfrog - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: configure-log-integration-amdgpu path: | From 726f1eb6a91810ff4debb0895f97cf9cc103f1d6 Mon Sep 17 00:00:00 2001 From: Patrick Mullen Date: Wed, 5 Feb 2025 15:59:22 -0500 Subject: [PATCH 2/3] Fix remaining update to v4 artifacts --- .github/workflows/ci-short.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-short.yml b/.github/workflows/ci-short.yml index 84dc1f92a7de..7d3f40800b9e 100644 --- a/.github/workflows/ci-short.yml +++ b/.github/workflows/ci-short.yml @@ -35,7 +35,7 @@ jobs: run: | cmake -DCMAKE_CXX_FLAGS=-Werror -Bbuild-copyright-check cmake --build build-copyright-check -t check-copyright - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: configure-log-style path: build-copyright-check/CMakeFiles/CMakeOutput.log From 1e324a53efc6525026d25f2756c0a3c9a18542d8 Mon Sep 17 00:00:00 2001 From: Patrick Mullen Date: Wed, 5 Feb 2025 16:45:27 -0500 Subject: [PATCH 3/3] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 770aa5022209..9bc77fce50c3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - [[PR 1161]](https://github.com/parthenon-hpc-lab/parthenon/pull/1161) Make flux field Metadata accessible, add Metadata::CellMemAligned flag, small perfomance upgrades ### Changed (changing behavior/API/variables/...) +- [[PR 1223]](https://github.com/parthenon-hpc-lab/parthenon/pull/1223) Update to v4 artifacts - [[PR 1216]](https://github.com/parthenon-hpc-lab/parthenon/pull/1216) Move to Kokkos 4.5 - [[PR 1191]](https://github.com/parthenon-hpc-lab/parthenon/pull/1191) Update Kokkos version to 4.4.1 - [[PR 1209]](https://github.com/parthenon-hpc-lab/parthenon/pull/1209) Ordered history output