Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hidden characters in the input file #1221

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

adamdempsey90
Copy link
Collaborator

PR Summary

An artemis user found that this

<parthenon/mesh>
refinement = static\r

was parsed incorrectly (after spending half a day to find the hidden \r character).

This PR does two things:

  • Adds a new unit test that exposes this bug
  • Adds a fix which strips out all the nasty characters \t\r\f\v\n immediately after reading a line in the input file.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@adamdempsey90
Copy link
Collaborator Author

@par-hermes format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant