Skip to content

Commit 05628da

Browse files
authored
fix!: minimum nodejs version (#1278)
1 parent 44e2da4 commit 05628da

File tree

5 files changed

+22
-29
lines changed

5 files changed

+22
-29
lines changed

.github/workflows/nodejs.yml

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [14.x]
19+
node-version: [18.x]
2020

2121
steps:
2222
- name: Install wasm-pack
@@ -31,23 +31,6 @@ jobs:
3131
- run: yarn
3232
- run: yarn build
3333

34-
build-docs:
35-
36-
runs-on: ubuntu-latest
37-
38-
strategy:
39-
matrix:
40-
node-version: [14.x]
41-
42-
steps:
43-
- uses: actions/checkout@v3
44-
- name: Use Node.js ${{ matrix.node-version }}
45-
uses: actions/setup-node@v3
46-
with:
47-
node-version: ${{ matrix.node-version }}
48-
- run: yarn
49-
- run: yarn build:docs
50-
5134
build-npm-release:
5235
# This test is to make sure sidecar can release a binary without any errors.
5336
# This script does not publish a release, but instead uses yarn to create a tarball and
@@ -59,7 +42,7 @@ jobs:
5942

6043
strategy:
6144
matrix:
62-
node-version: [14.x]
45+
node-version: [18.x]
6346

6447
steps:
6548
- uses: actions/checkout@v3

.github/workflows/pr.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ jobs:
1818
- name: Checkout files
1919
uses: actions/checkout@v3
2020

21-
- name: Install Node v16
21+
- name: Install Node v18
2222
uses: actions/setup-node@v3
2323
with:
24-
node-version: '16.13'
24+
node-version: '18.14'
2525

2626
- name: Get yarn cache directory path
2727
id: yarn-cache-dir-path
@@ -48,10 +48,10 @@ jobs:
4848
- name: Checkout files
4949
uses: actions/checkout@v3
5050

51-
- name: Install Node v16
51+
- name: Install Node v18
5252
uses: actions/setup-node@v3
5353
with:
54-
node-version: '16.13'
54+
node-version: '18.14'
5555

5656
- name: Get yarn cache directory path
5757
id: yarn-cache-dir-path
@@ -79,10 +79,10 @@ jobs:
7979
- name: Checkout files
8080
uses: actions/checkout@v3
8181

82-
- name: Install Node v16
82+
- name: Install Node v18
8383
uses: actions/setup-node@v3
8484
with:
85-
node-version: '16.13'
85+
node-version: '18.14'
8686

8787
- name: Get yarn cache directory path
8888
id: yarn-cache-dir-path
@@ -110,10 +110,10 @@ jobs:
110110
- name: Checkout files
111111
uses: actions/checkout@v3
112112

113-
- name: Install Node v16
113+
- name: Install Node v18
114114
uses: actions/setup-node@v3
115115
with:
116-
node-version: '16.13'
116+
node-version: '18.14'
117117

118118
- name: Get yarn cache directory path
119119
id: yarn-cache-dir-path

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
14
1+
v18.15

README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ learn more.
2828

2929
## Prerequisites
3030

31+
### <= v15.0.0
3132
This service requires Node versions 14 or higher.
3233

3334
Compatibility:
@@ -39,6 +40,15 @@ Compatibility:
3940
| v18.x.x | Stable |
4041
| v19.x.x | Pending |
4142

43+
### >= v16.0.0
44+
This service requires Node versions 18.14 or higher.
45+
46+
Compatibility:
47+
| Node Version | Stablility |
48+
|---------------|:-----------:|
49+
| v18.14.x | Stable |
50+
| v19.x.x | Pending |
51+
4252
NOTE: Node LTS (`long term support`) versions start with an even number, and odd number versions are subject to a 6 month testing period with active support before they are unsupported. It is recommended to use sidecar with a stable actively maintained version of node.js.
4353

4454
## Table of contents

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"url": "git+https://github.com/paritytech/substrate-api-sidecar.git"
1818
},
1919
"engines": {
20-
"node": ">=14"
20+
"node": ">=18.14"
2121
},
2222
"bugs": {
2323
"url": "https://github.com/paritytech/substrate-api-sidecar/issues"

0 commit comments

Comments
 (0)