Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRAME] Benchmarking should count deletions #7521

Open
ggwpez opened this issue Feb 10, 2025 · 0 comments
Open

[FRAME] Benchmarking should count deletions #7521

ggwpez opened this issue Feb 10, 2025 · 0 comments

Comments

@ggwpez
Copy link
Member

ggwpez commented Feb 10, 2025

The benchmarked weights currently only contain reads and writes. With state version 1, there is a big over-estimation when deleting keys since it will still consider the MEL bound for those.
Need to split it up into READS/WRITES/DELETES and then limit the deletion PoV weight of the value to 32.

I did not check the code recently on how the backend would know that something is deleted instead of written, but probably possibly to find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant