Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper tests for on-demand relays #2475

Closed
svyatonik opened this issue May 25, 2022 · 1 comment
Closed

Proper tests for on-demand relays #2475

svyatonik opened this issue May 25, 2022 · 1 comment
Milestone

Comments

@svyatonik
Copy link
Contributor

Currently all relays (finality, parachains, messages) are well isolated from the Substrate client and thus have good test coverage. On-demand relays, otoh, are using Substate Client directly, so no proper tests. Instead, they have some fn, which contains almost all relay logic and is not dependent on the Client. But this almost is not enough.

Since on-demand relays complexity has increased recently (with adding on-demand parachains relay), I suggest to introduce some local trait (which is impl for Client) and to add proper tests for both on-demand relays.

@EmmanuellNorbertTulbure EmmanuellNorbertTulbure transferred this issue from paritytech/parity-bridges-common Aug 25, 2023
@the-right-joyce the-right-joyce transferred this issue from paritytech/polkadot-sdk Aug 25, 2023
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure added this to the Nice To Have milestone Sep 1, 2023
@svyatonik
Copy link
Contributor Author

superseded by #3002

@svyatonik svyatonik closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants