Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid multiple reconnects of the same client during the single reconnect call #2444

Closed
Tracked by #2091
svyatonik opened this issue Mar 2, 2023 · 1 comment
Closed
Tracked by #2091

Avoid multiple reconnects of the same client during the single reconnect call #2444

svyatonik opened this issue Mar 2, 2023 · 1 comment
Assignees
@serban300
Milestone
Some Day Maybe

Comments

@svyatonik
Copy link
Contributor

#1927 introduces change, that calls reconnect on clients, used by underlying on-demand header relays. So in worst case, we'll reconnect to (for RBH<>WBH case):

  • to RBH and WBH clients in MessagesTarget::reconnect;
  • to Rococo and WBH in OnDemandParachainsRelay::reconnect;
  • to Rococo and WBH in OnDemandHeadersRelay::reconnect.

So the single MessagesTarget::reconnect call leads to x3 reconnects to WBH node. This (x3 connect+disconnect in 1 sec) may be treated as an improper behavior if e.g. the node is behind some load balancer and may lead to banning the relayer. Would be good to fix it soon.
Closed
34 tasks
@serban300 serban300 self-assigned this May 11, 2023
svyatonik referenced this issue Jul 17, 2023
@dependabot
Bump clap from 4.0.27 to 4.0.29 (#1928)
2e6f4be 
Bumps [clap](https://github.com/clap-rs/clap) from 4.0.27 to 4.0.29.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.0.27...v4.0.29)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure transferred this issue from paritytech/parity-bridges-common Aug 25, 2023
@the-right-joyce the-right-joyce transferred this issue from paritytech/polkadot-sdk Aug 25, 2023
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure added this to the Some Day Maybe milestone Sep 1, 2023
@svyatonik
Copy link
Contributor Author

Is not actual anymore because of #3002

@svyatonik svyatonik closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
None yet
Projects
None yet
Milestone
Some Day Maybe
Development

No branches or pull requests
3 participants
@svyatonik @serban300 @EmmanuellNorbertTulbure