Flaky "Invalid Transaction" errors in Uniswap V2 periphery migration tests

[sekisamu]

Description

After partially fixing #266, both hardhat-polkadot 0.1.5 and 0.1.8 now produce consistent but non-deterministic Invalid Transaction errors. The error occurs randomly in different test cases across multiple test runs.

Environment

• polkadot-sdk version: c40b36c3a7c208f9a6837b80812473af3d9ba7f7
• Test repository: https://github.com/papermoonio/v2-periphery-polkadot/tree/bugfix/flaky
• hardhat-polkadot: 0.1.5 and 0.1.8 (both show same behavior)
• resolc: 0.3.0

Steps to Reproduce

1. Build nodes

git clone https://github.com/paritytech/polkadot-sdk
cd polkadot-sdk
git checkout c40b36c3a7c208f9a6837b80812473af3d9ba7f7

# Build eth-rpc
cargo build -p pallet-revive-eth-rpc --release

# Build revive-dev-node
cd substrate/frame/revive/dev-node/node
cargo build --release

2. Prepare test repository

git clone https://github.com/papermoonio/v2-periphery-polkadot
cd v2-periphery-polkadot
git checkout bugfix/flaky

3. Create .env file

Create .env file in the project root:

LOCAL_PRIV_KEY=0x5fb92d6e98884f76de468fa3f6278f8807c48bebc13595d45af5bdc4da702133
AH_PRIV_KEY=xxx

4. Test with hardhat-polkadot 0.1.5

Note: pnpm-lock.yaml contains hardhat-polkadot 0.1.5

pnpm install
USE_POLKAVM=true npx hardhat test ./test/ExampleComputeLiquidityValue.spec.ts

Results vary between runs:

• Run 1: https://github.com/papermoonio/v2-periphery-polkadot/blob/bugfix/flaky/0.1.5_1.txt
• Run 2: https://github.com/papermoonio/v2-periphery-polkadot/blob/bugfix/flaky/0.1.5_2.txt

5. Test with hardhat-polkadot 0.1.8

Note: package-lock.json contains hardhat-polkadot 0.1.8

rm -rf node_modules
npm install
USE_POLKAVM=true npx hardhat test ./test/ExampleComputeLiquidityValue.spec.ts

Results vary between runs:

• Run 1: https://github.com/papermoonio/v2-periphery-polkadot/blob/bugfix/flaky/0.1.8_1.txt
• Run 2: https://github.com/papermoonio/v2-periphery-polkadot/blob/bugfix/flaky/0.1.8_2.txt

Important Note

When running the same revive-dev-node and eth-rpc binaries manually (not through hardhat), these errors do NOT occur, suggesting the issue may be related to:

• State management between tests
• Block production timing

[athei]

"Invalid" transaction is related to gas estimation. It is this one: paritytech/contract-issues#75

[sekisamu]

@athei I think we should pay more attention to the params in the error msg: https://github.com/papermoonio/v2-periphery-polkadot/blob/bugfix/flaky/0.1.8_1.txt#L14C184-L14C288672

This parameter is too long to be a function call, but obviously its format is not that of a PVM contract either.

[athei]

What do you mean? This is an instantiation and the data contains the "PVM" magic bytes:

{
  "chainId": "0x190f1b44",
  "nonce": "0x14",
  "maxPriorityFeePerGas": "0xc8",
  "maxFeePerGas": "0x898",
  "gasLimit": "0x140500c67ddd1f2f",
  "value": "0x0",
  "data": "0x50564d00..."
}

144k ins fine as a payload. So it should be the gas estimation.

[bee344]

@sekisamu I had to make some changes to have it running with the latest versions:

package.json

{
  "name": "v2-periphery-polkadot",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "description": "",
  "devDependencies": {
    "@nomicfoundation/hardhat-chai-matchers": "^2.0.0",
    "@nomicfoundation/hardhat-ethers": "^3.0.0",
    "@nomicfoundation/hardhat-ignition": "^0.15.0",
    "@nomicfoundation/hardhat-ignition-ethers": "^0.15.0",
    "@nomicfoundation/hardhat-network-helpers": "^1.0.0",
    "@nomicfoundation/hardhat-toolbox": "^5.0.0",
    "@nomicfoundation/hardhat-verify": "^2.0.0",
    "@parity/hardhat-polkadot": "^0.1.11-pre1",
    "@typechain/ethers-v6": "^0.5.0",
    "@typechain/hardhat": "^9.0.0",
    "@types/chai": "^4.2.0",
    "@types/mocha": "^10.0.10",
    "@types/node": ">=18.0.0",
    "chai": "^4.2.0",
    "dotenv": "^16.5.0",
    "ethereumjs-util": "^7.1.5",
    "ethers": "^6.4.0",
    "hardhat": "^2.26.0",
    "hardhat-gas-reporter": "^1.0.8",
    "solidity-coverage": "^0.8.0",
    "ts-node": ">=8.0.0",
    "typechain": "^8.3.0",
    "typescript": ">=4.5.0"
  },
  "dependencies": {
    "@uniswap/lib": "github:papermoonio/uniswap-lib-polkadot",
    "@uniswap/v2-core": "github:papermoonio/uniswap-v2-polkadot"
  },
  "overrides": {
    "hardhat": "^2.26.0"
  }
}

hardhat.config.js

import { HardhatUserConfig } from "hardhat/config";
import "@nomicfoundation/hardhat-toolbox";
import "@nomicfoundation/hardhat-ethers";
import "@parity/hardhat-polkadot";
import * as dotenv from "dotenv";
dotenv.config();

const usePolkaVM = process.env.USE_POLKAVM === "true";

const config: HardhatUserConfig = {
  solidity: "0.8.30",
  mocha: {
    timeout: 100000
  },
  networks: {
    hardhat: usePolkaVM
      ? {
          polkavm: true,
          nodeConfig: {
            nodeBinaryPath: "./revive-dev-node-linux-x64",
            rpcPort: 8000,
            dev: true,
          },
          adapterConfig: {
            adapterBinaryPath: "./eth-rpc-linux-x64",
            dev: true,
          },
        }
      : {},
    local: {
      polkavm: true,
      url: 'http://127.0.0.1:8545',
      accounts: [
        process.env.LOCAL_PRIV_KEY as string,
        process.env.AH_PRIV_KEY as string,
      ],
    },
    ah: {
      polkavm: true,
      url: "https://westend-asset-hub-eth-rpc.polkadot.io",
      accounts: [
        process.env.AH_PRIV_KEY as string,
      ],
    },
  }
};

export default config;

Get rid of every getWallets() call because they won't work. Instead of [walletForLargeContract] = getWallets(1) just use await ethers.getSigners() since the rpc now has 6 accounts available.

With those changes and running USE_POLKAVM=true npx hardhat test ./test/ExampleComputeLiquidityValue.spec.ts with both the LOCAL_PRIV_KEY and AH_PRIV_KEY with the same key (the one you defined above), I get these results:

Uploading factory dependency in UniswapV2Factory...


  ExampleComputeLiquidityValue
    ✔ correct factory address
    #getLiquidityValue
      ✔ correct for 5 shares
      ✔ correct for 7 shares
router address 0x84f626fbF31cf3FFE4B606b5efA724A46d54E83e
      1) correct after swap
      fee on
        2) correct after swap
    #getReservesAfterArbitrage
      ✔ 1/400
      ✔ 1/200
      ✔ 1/100 (same price)
      ✔ 1/50
      ✔ 1/25
      ✔ 25/1
      ✔ works with large numbers for the price
    #getLiquidityValue
      fee is off
        ✔ produces the correct value after arbing to 1:105
        ✔ produces the correct value after arbing to 1:95
        ✔ produces correct value at the current price
        ✔ gas current price
        ✔ gas higher price
        ✔ gas lower price
        after a swap
          3) "before each" hook: swap to ~1:25 for "is roughly 1/25th liquidity"
      fee is on
        ✔ gas current price
        ✔ gas higher price
        ✔ gas lower price
        no fee to be collected
          4) "before each" hook for "produces the correct value after arbing to 1:105"


  19 passing (1m)
  4 failing

  1) ExampleComputeLiquidityValue
       #getLiquidityValue
         correct after swap:
     ProviderError: Failed to instantiate contract: Module(ModuleError { index: 5, error: [11, 0, 0, 0], message: Some("ContractTrapped") })
      at HttpProvider.request (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/hardhat@2.26.3_ts-node@10.9.2_@types+node@22.15.30_typescript@5.8.3__typescript@5.8.3/node_modules/hardhat/src/internal/core/providers/http.ts:116:21)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async HardhatEthersProvider.estimateGas (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/internal/hardhat-ethers-provider.ts:246:27)
      at async /home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:335:35
      at async Promise.all (index 0)
      at async HardhatEthersSigner._sendUncheckedTransaction (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:356:7)
      at async HardhatEthersSigner.sendTransaction (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:181:18)
      at async send (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/contract.ts:313:20)
      at async Proxy.swapExactTokensForTokens (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/contract.ts:352:16)
      at async Context.<anonymous> (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/test/ExampleComputeLiquidityValue.spec.ts:70:18)

  2) ExampleComputeLiquidityValue
       #getLiquidityValue
         fee on
           correct after swap:
     ProviderError: Failed to instantiate contract: Module(ModuleError { index: 5, error: [11, 0, 0, 0], message: Some("ContractTrapped") })
      at HttpProvider.request (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/hardhat@2.26.3_ts-node@10.9.2_@types+node@22.15.30_typescript@5.8.3__typescript@5.8.3/node_modules/hardhat/src/internal/core/providers/http.ts:116:21)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async HardhatEthersProvider.estimateGas (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/internal/hardhat-ethers-provider.ts:246:27)
      at async /home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:335:35
      at async Promise.all (index 0)
      at async HardhatEthersSigner._sendUncheckedTransaction (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:356:7)
      at async HardhatEthersSigner.sendTransaction (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:181:18)
      at async send (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/contract.ts:313:20)
      at async Proxy.swapExactTokensForTokens (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/contract.ts:352:16)
      at async Context.<anonymous> (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/test/ExampleComputeLiquidityValue.spec.ts:102:20)

  3) ExampleComputeLiquidityValue
       #getLiquidityValue
         fee is off
           after a swap
             "before each" hook: swap to ~1:25 for "is roughly 1/25th liquidity":
     ProviderError: Failed to instantiate contract: Module(ModuleError { index: 5, error: [11, 0, 0, 0], message: Some("ContractTrapped") })
      at HttpProvider.request (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/hardhat@2.26.3_ts-node@10.9.2_@types+node@22.15.30_typescript@5.8.3__typescript@5.8.3/node_modules/hardhat/src/internal/core/providers/http.ts:116:21)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async HardhatEthersProvider.estimateGas (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/internal/hardhat-ethers-provider.ts:246:27)
      at async /home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:335:35
      at async Promise.all (index 0)
      at async HardhatEthersSigner._sendUncheckedTransaction (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:356:7)
      at async HardhatEthersSigner.sendTransaction (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/@nomicfoundation+hardhat-ethers@3.0.9_ethers@6.14.3_hardhat@2.26.3_ts-node@10.9.2_@types+node_pijmromqhb2ygufjcmuym4cvz4/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:181:18)
      at async send (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/contract.ts:313:20)
      at async Proxy.swapExactTokensForTokens (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/contract.ts:352:16)
      at async Context.<anonymous> (/home/bee344/Documentos/parity/revive/v2-periphery-polkadot/test/ExampleComputeLiquidityValue.spec.ts:278:22)

  4) ExampleComputeLiquidityValue
       "before each" hook for "produces the correct value after arbing to 1:105":
     Error: transaction execution reverted (action="sendTransaction", data=null, reason=null, invocation=null, revert=null, transaction={ "data": "", "from": "0x3Cd0A705a2DC65e5b1E1205896BaA2be8A07c6e0", "to": null }, receipt={ "_type": "TransactionReceipt", "blobGasPrice": null, "blobGasUsed": null, "blockHash": "0x70fdf0975a5da449b43c5d0c6e215b64f8ab7bdc0638591a33a2cd8ac62761da", "blockNumber": 359, "contractAddress": "0xaB29e30a753C802b0DdE6aC888e8Af0193e4FCfd", "cumulativeGasUsed": "0", "from": "0x3Cd0A705a2DC65e5b1E1205896BaA2be8A07c6e0", "gasPrice": "1000", "gasUsed": "1442490108157000000", "hash": "0x5d9d4966a37b7073113a51a57f15bfffb172a11d1a0774d08916f09361c85397", "index": 1, "logs": [  ], "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "root": null, "status": 0, "to": null }, code=CALL_EXCEPTION, version=6.14.3)
      at makeError (node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/utils/errors.ts:698:21)
      at assert (node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/utils/errors.ts:719:25)
      at checkReceipt (node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/providers/provider.ts:1607:19)
      at ContractTransactionResponse.wait (node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/providers/provider.ts:1624:24)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async ContractTransactionResponse.wait (node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/wrappers.ts:136:25)
      at async Proxy.waitForDeployment (node_modules/.pnpm/ethers@6.14.3/node_modules/ethers/src.ts/contract/contract.ts:847:13)
      at async v2Fixture (test/shared/fixtures.ts:80:3)
      at async Context.<anonymous> (test/ExampleComputeLiquidityValue.spec.ts:21:21)

[bee344]

Oh and use the node and rpc from the releases