File tree Expand file tree Collapse file tree 1 file changed +11
-3
lines changed Expand file tree Collapse file tree 1 file changed +11
-3
lines changed Original file line number Diff line number Diff line change @@ -34,6 +34,7 @@ def install_pants(
34
34
check = True ,
35
35
)
36
36
python = venv_dir / "bin" / "python"
37
+ install_log = venv_dir / "pants-install.log"
37
38
38
39
find_links_options = ("--find-links" , find_links ) if find_links else ()
39
40
@@ -44,6 +45,8 @@ def pip_install(*args: str) -> None:
44
45
"-sE" ,
45
46
"-m" ,
46
47
"pip" ,
48
+ "--log" ,
49
+ install_log ,
47
50
"install" ,
48
51
"--quiet" ,
49
52
* find_links_options ,
@@ -52,9 +55,14 @@ def pip_install(*args: str) -> None:
52
55
check = True ,
53
56
)
54
57
55
- # Grab the latest pip, but don't advance setuptools past 58 which drops support for the
56
- # `setup` kwarg `use_2to3` which Pants 1.x sdist dependencies (pystache) use.
57
- pip_install ("-U" , "pip" , "setuptools<58" , "wheel" )
58
+ # Pin Pip to 22.3.1 (currently latest). The key semantic that should be preserved by the Pip
59
+ # we use is that --find-links are used as a fallback only and PyPI is preferred. This saves us
60
+ # money by avoiding fetching wheels from our S3 bucket at https://binaries.pantsbuild.org unless
61
+ # absolutely needed.
62
+ #
63
+ # Also, we don't advance setuptools past 58 which drops support for the `setup` kwarg `use_2to3`
64
+ # which Pants 1.x sdist dependencies (pystache) use.
65
+ pip_install ("-U" , "pip==22.3.1" , "setuptools<58" , "wheel" )
58
66
pip_install ("--progress-bar" , "off" , * pants_requirements )
59
67
60
68
You can’t perform that action at this time.
0 commit comments