Skip to content

Commit 62894d0

Browse files
authored
Fix new draft-release release flow: avoid duplicates, capture changelog (#439)
As observed in #432 (comment), after #432, release CI has two problems: - It creates two releases, one as a draft that the artifacts are uploaded too, and then one that's published. I'm guessing this is because the `name` key wasn't set on the draft uploads - The release notes couldn't be created, because the repo and its code (particularly `CHANGES.md`) wasn't available in the publishing step
1 parent e9f52bd commit 62894d0

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ jobs:
102102
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
103103
with:
104104
tag_name: ${{ needs.determine-tag.outputs.release-tag }}
105+
name: scie-pants ${{ needs.determine-tag.outputs.release-version }}
105106
draft: true
106107
# placeholder body to help someone track down why a release is still in draft:
107108
body: "Release job in progress: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
@@ -116,6 +117,11 @@ jobs:
116117
runs-on: ubuntu-22.04
117118
steps:
118119
# Now, do the human-facing prep on the release (changelog etc.), and publish it
120+
- name: Checkout scie-pants ${{ needs.determine-tag.outputs.release-tag }}
121+
uses: actions/checkout@v4
122+
with:
123+
ref: ${{ needs.determine-tag.outputs.release-tag }}
124+
119125
- name: Prepare Changelog
120126
id: prepare-changelog
121127
uses: a-scie/actions/[email protected]

0 commit comments

Comments
 (0)