Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Temporary flake8 exlcusions from Python 3.11 cutover #21647

Open
cburroughs opened this issue Nov 14, 2024 · 0 comments
Open

Resolve Temporary flake8 exlcusions from Python 3.11 cutover #21647

cburroughs opened this issue Nov 14, 2024 · 0 comments
Assignees
@cburroughs
Labels
bug

Comments

@cburroughs
Copy link
Contributor

build-support/flake8/.flake8

Followup from: #21528
@cburroughs cburroughs added the bug label Nov 14, 2024
@cburroughs cburroughs self-assigned this Nov 14, 2024
@cburroughs cburroughs mentioned this issue Dec 4, 2024
Merged
cburroughs added a commit that referenced this issue Dec 6, 2024
@cburroughs
enable C420: Unnecessary dict comprehension (#21715)
772cf4b 
This was disabled to minimize changes during the Python 3.11 upgrade.

See
https://github.com/adamchainz/flake8-comprehensions?tab=readme-ov-file#c420-unnecessary-dict-comprehension---rewrite-using-dictfromkeys

ref #21647
cburroughs added a commit to cburroughs/pants that referenced this issue Dec 20, 2024
@cburroughs
E721: Do not compare types, use 'isinstance()'
8290d3e 
ref pantsbuild#21647
@cburroughs cburroughs mentioned this issue Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cburroughs cburroughs

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cburroughs