Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when building aren't linked or aggregated #350

Open
zellyn opened this issue May 25, 2018 · 8 comments
Open

Errors when building aren't linked or aggregated #350

zellyn opened this issue May 25, 2018 · 8 comments

Comments

@zellyn
Copy link

zellyn commented May 25, 2018

The closest issue I could find is #34, which is old, closed, and implies that the problem should be fixed. However, when I compile directly or as part of running a test, the pants errors are simply printed in the window named "Pants Console:". They are not clickable. There is also no list of errors in any UI element.

@wisechengyi
Copy link
Collaborator

wisechengyi commented May 25, 2018

Hi @zellyn,

Thanks for the report.

They are not clickable.

Currently the plugin only parses line with [error]

public static final String ERROR_TAG = "[error]";

However, if it does not work for you. Please kindly attach some examples or screenshots.

There is also no list of errors in any UI element.

That is by design, because formatting in UI is hard to do and does not provide consistent experience with the command line.

@zellyn
Copy link
Author

zellyn commented May 25, 2018

                         symbol:   class DbDispute
                         location: class VersionsTest
                       disputes-api/src/test/java/com/squareup/disputesapi/convert/VersionsTest.java:83: error: cannot find symbol
                           DbDispute newer = DbDisputes.convert(TestDisputes.CBMS_DISPUTE_W3);
                           ^

@zellyn
Copy link
Author

zellyn commented May 25, 2018

image

@wisechengyi
Copy link
Collaborator

wisechengyi commented May 25, 2018

What version of pants is this?

The code is working correctly, but it seems that it's no longer [error] anymore, but error:

@zellyn
Copy link
Author

zellyn commented May 25, 2018

Ugh. It's probably because we're on an old (very lightly forked) version: pants -v reports 1.2.1-rc2018051601. This is good ammunition to spur upgrades and unforking :-)

@zellyn zellyn closed this as completed May 25, 2018
@zellyn
Copy link
Author

zellyn commented May 25, 2018

Hmmm. More info. The error message format seems to vary depending on whether you use zinc or javac. We use javac (support for which just got merged two weeks ago).

@zellyn zellyn reopened this May 25, 2018
@wisechengyi
Copy link
Collaborator

Interesting, so we can probably add error:. If the format difference is minimal, then the change should be trivial.

@JasonRosenberg
Copy link

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants