Is it possible to add options dynamicly from a valid list/tuple?

[m986883511]

default_need_change_config_list may be more than 5 item, the code is too long.

default_need_change_config_list = [
          'cpu_allocation_ratio', 
          'ram_allocation_ratio', 
          'disk_allocation_ratio', 
          'vcpu_pin_set',
          'reserved_host_memory_mb'
...
      ]

@nova.command()
@click.option('--cpu_allocation_ratio')
@click.option('--ram_allocation_ratio')
@click.option('--disk_allocation_ratio')
@click.option('--vcpu_pin_set')
@click.option('--reserved_host_memory_mb')
def config_host_nova_settings(cpu_allocation_ratio,ram_allocation_ratio,disk_allocation_ratio,vcpu_pin_set,reserved_host_memory_mb):
    if cpu_allocation_ratio is not None:
        update_dict[cpu_allocation_ratio ]=cpu_allocation_ratio 
   if ram_allocation_ratiois not None:
        update_dict[ram_allocation_ratio]=ram_allocation_ratio
  ....
   value = business.NovaEndPoint().config_host_nova_settings(ctxt={}, update_dict=update_dict)
    click.secho(value, fg='green')

I think it redundant and cumbersome. Is there a better way?

like:

default_need_change_config_list = [
          'cpu_allocation_ratio', 
          'ram_allocation_ratio', 
          'disk_allocation_ratio', 
          'vcpu_pin_set',
          'reserved_host_memory_mb'
...
      ]

@nova.command()
@click.dynamic_options(options=default_need_change_config_list )
def config_host_nova_settings(*args, **kwargs):
    for i in default_need_change_config_list:
    if i in kwargs:
        update_dict[i]=i
   value = business.NovaEndPoint().config_host_nova_settings(ctxt={}, update_dict=update_dict)
    click.secho(value, fg='green')

[m986883511]

I found this is test ok, code is shorter, but option is valid.

@nova.command()
@click.option('--cpu_allocation_ratio')
@click.option('--ram_allocation_ratio')
@click.option('--disk_allocation_ratio')
@click.option('--vcpu_pin_set')
@click.option('--reserved_host_memory_mb')
def config_host_nova_settings(*args, **kwargs):
    update_dict = {key:value for key, value in kwargs.items() if value is not None}
    value = business.NovaEndPoint().config_host_nova_settings(ctxt={}, config=update_dict)
    assert isinstance(value, dict), f'return value should be dict, but is {type(value)}'
    value = json.dumps(value, indent=4)
    click.secho(value, fg='green')

[KotlinIsland]

I have a very similar scenario, converting from argparse to click:

def main():
    parser = argparse.ArgumentParser()
    parser.add_argument("--foo", action="store_true")
    for switch, name in [("a", "1"), ("b", "2"), ("c", "3"), ("d", "4"), ("e", "5")]:
        parser.add_argument(
            f"--{switch}days", action="store", type=float, help=f"Do something {name}"
        )
    parser.add_argument("--bar", action="store_true")

What I currently have is pretty cringe:

def _days(f):
    for switch, name in reversed([("a", "1"), ("b", "2"), ("c", "3"), ("d", "4"), ("e", "5")]):
        click.option(
            f"--{switch}days", action="store", type=float, help=f"Do something {name}"
        )(f)
    return f
@click.command()
@click.option("--foo")
@_days
@click.option("--bar")
def main()

[KotlinIsland]

I wrote this helper:

def multi_option(options: Iterable[Callable[[T], T]]) -> Callable[[T], T]:
    """Add multiple click options as a decorator"""

    def handler(function: T) -> T:
        for option in reversed(tuple(options)):
            option(function)
        return function

    return handler

@click.command()
@multi_option(
    click.option(f"--{switch}days", help=f"Do something {name}")
    for switch, name in [("a", "1"), ("b", "2"), ("c", "3"), ("d", "4"), ("e", "5")]
)
def main(a, b, c): ...