Stop using datetime.utcnow() in tests #1308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-t-e-v-e-n-k
force-pushed
the
stop-using-utcnow
branch
2 times, most recently
from
90d6e72
to
172e239
Compare
pamelafox
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Thanks! As this is a bug fix, could you make it off the latest 3.x branch, per https://github.com/pallets-eco/flask-sqlalchemy/blob/main/CONTRIBUTING.rst#start-coding ?
davidism
reviewed
Feb 1, 2024
tests/test_model.py
Outdated
| @@ -14,6 +15,11 @@ | |||
| from flask_sqlalchemy.model import Model | |||
|
|
|||
|
|
|||
| class UTCNow(datetime): | |||
There was a problem hiding this comment.
Rather than making this a subclass with a tricky __new__, this should just be a function:
def now() -> datetime:
return datetime.now(timezone.utc)
s-t-e-v-e-n-k
force-pushed
the
stop-using-utcnow
branch
from
172e239
to
5bd2d07
Compare
s-t-e-v-e-n-k
force-pushed
the
stop-using-utcnow
branch
from
5bd2d07
to
ed32fa1
Compare
|
I have addressed both comments, thanks! |
pamelafox
approved these changes
Feb 2, 2024
davidism
reviewed
Feb 2, 2024
datetime.utcnow() is deprecated for Python 3.12+, and raises a warning. Since warnings are treated as errors, this results in test failures. Since utcnow calls are done by the SQLAlchemy mapping machinery, we need to use a function. Fixes pallets-eco#1303
s-t-e-v-e-n-k
force-pushed
the
stop-using-utcnow
branch
from
ed32fa1
to
2cbf3f2
Compare
|
@davidism Thanks, I've reverted that bit. |
|
Sorry, completely forgot about this PR and ended up fixing it myself when doing some updates. Thanks for working on it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime.utcnow() is deprecated for Python 3.12+, and raises a warning. Since warnings are treated as errors, this results in test failures. Since utcnow calls are done by the SQLAlchemy mapping machinery, we need to use a callable.
Fixes #1303
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.