Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim key #93

Closed
wants to merge 1 commit into from
Closed

Trim key #93

wants to merge 1 commit into from

Conversation

jared2501
Copy link

@jared2501 jared2501 commented Aug 4, 2018

Fixes #92.

@jared2501
Copy link
Author

cc @bavardage @nmiyake

Copy link
Contributor

@nmiyake nmiyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I understand the problem as stated in the PR, but am a bit hesitant about making the change at this layer -- I think it makes sense for the core data structure's serialization and deserialization be more well-defined/stringent.

It feels like trimming would be more well-suited at the layer that reads the file from disk -- is that controlled in ECV or by client libraries? I would much prefer a solution that trimmed the input that is read from the file.

@CRogers CRogers closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim key file
3 participants