Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SerializableError throws NPE if any of the SafeArgs are null #66

Open
mglazer opened this issue Nov 29, 2017 · 1 comment
Open

SerializableError throws NPE if any of the SafeArgs are null #66

mglazer opened this issue Nov 29, 2017 · 1 comment

Comments

@mglazer
Copy link

mglazer commented Nov 29, 2017

From: https://github.com/palantir/http-remoting-api/blob/develop/errors/src/main/java/com/palantir/remoting/api/errors/SerializableError.java#L119

This shouldn't thrown an NPE if the call to .getValue() returns null (which can happen if the caller doesn't do something like Strings.nullToEmpty() on all possible values).
@schlosna
Copy link
Contributor

@mglazer @uschi2000 is this fixed by #73 ?

@iamdanfox iamdanfox mentioned this issue Jul 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlosna @mglazer