how is PartialServiceConfiguration class being used?

[qinfchen]

ClientConfiguration can be created using ServiceConfiguration and there is no easy way to convert PartialServiceConfiguration to ServiceConfiguration or vice versa even though they are pretty much identical except for the absence of security. I would like know more about how we intend to use the PartialServiceConfiguration class

EDIT: saw ServiceConfigurationFactor.propagateDefaults and answered my question above.

[qinfchen]

Can we make ServiceConfigurationFactory.propagateDefaults public?

[uschi2000]

What's the use-case for this?

[qinfchen]

Having a PartialServiceConfiguration declare outside the service discovery block like multipass'

auth:
  legacyModeEnabled: false
  multipass:
    security:
      trustStorePath: var/security/trustStore.jks
    uris:
    - https://multipass.palantir.dev:8643/multipass/api

or slate's postgate data source config

- dataSourcePoolCacheTimeout: 1m
  databaseName: palantir
  driver: org.postgresql.ds.PGSimpleDataSource
  maximumDataSourcePoolSize: 30
  name: Foundry
  portNumber: 5432
  postgate:
    uris: https://spp.palantir.dev:6473/postgate/api/
  serverName: postgres.palantir.dev
  type: foundry

It'd be great if we can specify service configuration outside of service discovery without requiring ssl block. Unless we are encouraging teams to only take service configuration from service discovery?

[uschi2000]

In order to use propagateDefaults, you'd need a handle on a ServiceConfigBlock; if you have one of those, why not use ServiceConfigurationFactory#get ?

[qinfchen]

ServiceConfigBlock may not have the corresponding service config block for the PartialServiceConfiguration. I wonder if we should expose a convenient method of converting PartialServiceConfiguration to a ServiceConfiguration by filling in the defaults that are not present, which is what propagateDefaults does mostly

[uschi2000]

Such a method exists: build a custom ServiceConfigBlock and then call get().

[meditativeape]

ServiceConfigurationFactory#get only works for services defined in the ServicesConfigBlock. In some places, we define partial service configurations outside of the service discovery block, for example workers, and event consumers. The defaults in ServicesConfigBlock should get propagated to those as well, but currently there's no good way of doing that.

[ash211]

I had to do this also, workaround is to build a ServicesConfigBlock with a named service and then retrieve the same service back.

    protected static final PartialServiceConfiguration STATS_CONFIG =
            PartialServiceConfiguration.of(Lists.newArrayList(STATS_URI + "api/"), Optional.of(SSL_CONFIGURATION));

<snip>

        // TODO(aash): is going through a ServiceConfigurationFactory the best way to convert
        // PartialServiceConfiguration -> ClientConfiguration ?
        stats = JaxRsClient.create(FoundryStatsService.class, USER_AGENT, ClientConfigurations.of(
                ServiceConfigurationFactory.of(
                        ServicesConfigBlock.builder().putServices("foundry-stats", STATS_CONFIG).build()).get(
                        "foundry-stats")));

@uschi2000 is this what you intend?

[uschi2000]

We can add a static method ServiceConfigurationFactory that turns a partial config into a full one, or throws if not all required fields are set.

[qinfchen]

+1, created a pr for this https://github.com/palantir/http-remoting-api/pull/54