Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper camel case regexp in ErrorType is not valid #110

Open
mateuszlitwin opened this issue Jul 26, 2018 · 1 comment
Open

Upper camel case regexp in ErrorType is not valid #110

mateuszlitwin opened this issue Jul 26, 2018 · 1 comment

Comments

@mateuszlitwin
Copy link

mateuszlitwin commented Jul 26, 2018

It does not accept single uppercase letter (https://github.com/palantir/http-remoting-api/blob/develop/errors/src/main/java/com/palantir/remoting/api/errors/ErrorType.java#L33), e.g. "Foo:B" will not be a valid error name.

Regexp like ([A-Z]([a-z0-9]+[A-Z])*[a-z0-9]*) could solve this issue.

@qinfchen
Copy link
Contributor

@divath, I believe that is intentional. We want the error type names to be concise and self-describable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants