From 438f81fd6dad4d1ce147b5a92d08d35c695ae49c Mon Sep 17 00:00:00 2001
From: Patrick Koenig <pkoenig10@gmail.com>
Date: Tue, 22 Jun 2021 20:26:40 -0700
Subject: [PATCH] Clarify UnknownRemoteException message (#659)
---
.../conjure/java/api/errors/UnknownRemoteException.java | 4 ++--
.../conjure/java/api/errors/UnknownRemoteExceptionTest.java | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java b/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java
index c2515ee22..fa8a539e6 100644
--- a/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java
+++ b/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java
@@ -42,14 +42,14 @@ public String getBody() {
}
public UnknownRemoteException(int status, String body) {
- super(String.format("Error %s. (Failed to parse response body as SerializableError.)", status));
+ super(String.format("Response status: %s", status));
this.status = status;
this.body = body;
}
@Override
public String getLogMessage() {
- return "Failed to parse response body as SerializableError.";
+ return getMessage();
}
@Override
diff --git a/errors/src/test/java/com/palantir/conjure/java/api/errors/UnknownRemoteExceptionTest.java b/errors/src/test/java/com/palantir/conjure/java/api/errors/UnknownRemoteExceptionTest.java
index 328f8c411..cfc42c2df 100644
--- a/errors/src/test/java/com/palantir/conjure/java/api/errors/UnknownRemoteExceptionTest.java
+++ b/errors/src/test/java/com/palantir/conjure/java/api/errors/UnknownRemoteExceptionTest.java
@@ -27,9 +27,8 @@ class UnknownRemoteExceptionTest {
@Test
public void testMessage() {
UnknownRemoteException exception = new UnknownRemoteException(404, "not found");
- assertThat(exception.getMessage())
- .isEqualTo("Error 404. (Failed to parse response body as SerializableError.)");
- assertThat(exception.getLogMessage()).isEqualTo("Failed to parse response body as SerializableError.");
+ assertThat(exception.getMessage()).isEqualTo("Response status: 404");
+ assertThat(exception.getLogMessage()).isEqualTo("Response status: 404");
}
@Test