Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Incompatible with Gazebo 7 #3

Open
sauronalexander opened this issue Nov 4, 2016 · 4 comments
Open

Version Incompatible with Gazebo 7 #3

sauronalexander opened this issue Nov 4, 2016 · 4 comments

Comments

@sauronalexander
Copy link

I found several issues when compiling with gazebo 7. In Reemc_Harward_Gazebo, imu_sensor should be std::share_ptr, and should be std::dynamic_pointer_cast instead of boost::dynamic_pointer_cast. Also, there are some function name changes, such as Orientation and etc.

CMakeList should set CMAKE_CXX_FLAGS with -std=c++0x. Thanks.

@awesomebytes
Copy link
Contributor

This package was updated 2 years ago for the last time, Gazebo 7 wasn't there at that point. I don't know if anyone at PAL is working on supporting Gazebo 7.

But if you find the fixes to make it work and provide a Pull Request I'm sure it will be appreciated.

@bmagyar
Copy link
Contributor

bmagyar commented Nov 4, 2016

To add to Sam's comment:
Gazebo is changing API within major version numbers. As far as I remember REEM-C as most PAL software supports the Indigo version.

Any pull requests supporting higher versions of Gazebo such as 7 need to be put on a new branch as it'd break compatibility with Gazebo 2-4.

@sauronalexander
Copy link
Author

Hi Sam, I am Alexander (the same guy did an intern during the summer). I am running simulation in Gazebo. I used to use Gazebo 2, but there is all kinds of error. By updating the gazebo packages, some error are eliminated. It seemed after changing some code in this package, it needs another API called gazebo-pkgs. I have tried lots of methods to work around all the errors. It seems working at this moment. Thanks.

@v-lopez
Copy link

v-lopez commented Nov 7, 2016

Hi @sauronalexander, I would suggest addressing the issues you might have with gazebo 2, as it is the supported platform like @bmagyar and @awesomebytes said. Nevertheless if you want to use gazebo 7, feel free to create make this package compatible with Gazebo 7 in a new branch.

We might make it compatible in the future, but at the moment it's not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants