Skip to content

Commit 89a8a0a

Browse files
committed
Cleanup comments in build files
1 parent e21b687 commit 89a8a0a

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

Cargo.toml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@
22
resolver = "2"
33
members = [ "crates/*"]
44

5+
[workspace.package]
6+
version = "0.0.0"
7+
edition = "2021"
8+
rust-version = "1.64"
9+
authors = ["Estuary developers <[email protected]>"]
10+
readme = "./README.md"
11+
homepage = "https://estuary.dev/"
12+
repository = "https://github.com/estuary/flow"
13+
license = "BSL"
14+
515
[workspace.dependencies]
616
addr = {version="0.15.4", features=["idna", "std","psl"]}
717
anyhow = "1.0"
@@ -61,7 +71,6 @@ protobuf-parse = "3.1"
6171
rand = "0.8"
6272
regex = "1.5"
6373

64-
# TODO: some usages of reqwest were using native-tls. Verify it's ok to use rustls everywhere.
6574
reqwest = { version = "0.11", default_features = false, features = ["json", "rustls-tls", "stream"] }
6675
rocksdb = { version = "0.17", default-features = false, features = ["snappy", "rtti"] }
6776
rusqlite = { version = "0.27", features = ["bundled-full"]}
@@ -82,7 +91,6 @@ tempdir = "0.3"
8291
thiserror = "1.0"
8392
time = { version = "0.3", features = ["serde-well-known", "macros", "formatting", "parsing"] }
8493
tinyvec = {version = "1.6", features = ["alloc"]}
85-
# TODO: verify if it's ok to use "full" feature here, or if we need to be more conservative and selectively enable feeatures in crates
8694
tokio = { version = "1.15", features = ["full"] }
8795
tokio-util = { version = "0.7", features = ["io"] }
8896
tonic = {version = "0.8", features = [ "tls", "tls-roots"]}
@@ -103,7 +111,6 @@ zstd = "0.11.2"
103111

104112
# Used exclusively as dev-dependencies
105113
assert_cmd = "2.0"
106-
# TODO: upgrade insta. Version 1.15 seems to contain a breaking change to the serialization of RawValue, so holding off until I can confirm that's all it is.
107114
insta = { version = "1.20", features = ["redactions", "json", "yaml"]}
108115
criterion = "0.3"
109116
glob = "0.3"

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@ MUSL_TARGETS = \
211211
${PKGDIR}/bin/flow-schema-inference \
212212
${PKGDIR}/bin/flow-schemalate
213213

214-
# TODO: rename gnu-binaries to gnu-binaries
215214
.PHONY: linux-gnu-binaries
216215
linux-gnu-binaries: $(GNU_TARGETS)
217216

@@ -313,8 +312,6 @@ go-test-fast: $(GO_BUILD_DEPS) | ${PKGDIR}/bin/etcd ${PKGDIR}/bin/sops
313312
PATH=${PKGDIR}/bin:$$PATH ;\
314313
./go.sh test -p ${NPROC} --tags "${GO_BUILD_TAGS}" ./go/...
315314

316-
# ${PKGDIR}/bin/flow-connector-proxy ${PKGDIR}/bin/flowctl-admin ${PKGDIR}/bin/flowctl-go
317-
# $(GO_BUILD_DEPS) | ${PKGDIR}/bin/etcd ${PKGDIR}/bin/sops
318315
.PHONY: go-test-ci
319316
go-test-ci:
320317
PATH=${PKGDIR}/bin:$$PATH ;\

0 commit comments

Comments
 (0)