Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Ed25519 Private Key for Wallet #1550

Closed
b00f opened this issue Oct 14, 2024 · 4 comments · Fixed by #1584
Closed

Importing Ed25519 Private Key for Wallet #1550

b00f opened this issue Oct 14, 2024 · 4 comments · Fixed by #1584
Assignees
Labels
Milestone

Comments

@b00f
Copy link
Collaborator

b00f commented Oct 14, 2024

Currently, the wallet can only import BLS private keys. With command-line options, Pactus Wallet should be able to parse and import Ed25519 private keys as well.

@b00f b00f added the Wallet label Oct 14, 2024
@Ja7ad
Copy link
Contributor

Ja7ad commented Oct 16, 2024

Currently, the wallet can only import BLS private keys. With command-line options, Pactus Wallet should be able to parse and import Ed25519 private keys as well.

Anyway for konwn private key is BLS or ED25519 type?

I think we need to have a function PrivateKeyFromString for import bls or ed25519.

#1549

@b00f
Copy link
Collaborator Author

b00f commented Oct 16, 2024

We need to add an option to the command line command.

@Ja7ad
Copy link
Contributor

Ja7ad commented Oct 16, 2024

We need to add an option to the command line command.

This is not problem, similar this issue we have in #1549

@b00f
Copy link
Collaborator Author

b00f commented Oct 16, 2024

We may be able to detect the type of private key, by decoding the key. It is possible.

@Ja7ad Ja7ad added this to the v1.6.0 milestone Oct 30, 2024
@alidevjimmy alidevjimmy changed the title Importing Ed25519 Private Kay for Wallet Importing Ed25519 Private Key for Wallet Nov 3, 2024
@b00f b00f closed this as completed in #1584 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants