Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore .disabled files (closes #13) #58

Closed
wants to merge 1 commit into from

Conversation

Lemmmy
Copy link

@Lemmmy Lemmmy commented Apr 11, 2023

This PR adds a check for sibling .disabled in the local file validation routine. This solves #13, and will also work for resource pack files and others as mentioned in #51. There is still future room for Packwiz to do its own things as mentioned in #6 but this is a stop-gap solution to maintain support with MultiMC-based launchers.

@Lemmmy
Copy link
Author

Lemmmy commented Apr 11, 2023

Apologies for the indentation mistake there - editor misconfiguration on my end.

Copy link
Member

@comp500 comp500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change only stops packwiz-installer from redownloading a file when it is initially disabled, so updates to disabled mods will still be downloaded and need to be disabled again. Mod disabling needs to be synced with the optional mods system, so the optional mods dialog can be used to re-enable an optional mod that was disabled in the launcher.

I haven't looked at the relevant code in a while, but I think I was going to implement this by treating all files like optional files internally (but only showing mods marked as optional by default), and when a .disabled file is scanned the relevant file is marked as disabled.

@comp500 comp500 closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants