Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body reading timeouts don't seem to be retried properly #68

Open
comp500 opened this issue Aug 21, 2023 · 0 comments
Open

Request body reading timeouts don't seem to be retried properly #68

comp500 opened this issue Aug 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@comp500
Copy link
Member

comp500 commented Aug 21, 2023

There's a handler in

which should catch SocketTimeoutExceptions and retry the request? But I think this seems to only get called when the initial request gets run, not after HTTP2 headers have been sent and the request body is being streamed - see the following stacktrace:

java.net.SocketTimeoutException: timeout
	at okhttp3.internal.http2.Http2Stream$StreamTimeout.newTimeoutException(SourceFile:675)
	at okhttp3.internal.http2.Http2Stream$StreamTimeout.exitAndThrowIfTimedOut(SourceFile:684)
	at okhttp3.internal.http2.Http2Stream$FramingSource.read(SourceFile:379)
	at okhttp3.internal.connection.Exchange$ResponseBodySource.read(SourceFile:276)
	at okio.RealBufferedSource.read(SourceFile:189)
	at okio.ForwardingSource.read(SourceFile:27)
	at okio.HashingSource.read(SourceFile:70)
	at okio.ForwardingSource.read(SourceFile:27)
	at okio.RealBufferedSource.readAll(SourceFile:284)
	at link.infra.packwiz.installer.DownloadTask.download(SourceFile:226)
	at link.infra.packwiz.installer.UpdateManager.processIndex$lambda-14$lambda-13(SourceFile:372)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
@comp500 comp500 added the bug Something isn't working label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant