Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization & Localization support #65

Open
3TUSK opened this issue Jul 16, 2023 · 3 comments
Open

Internationalization & Localization support #65

3TUSK opened this issue Jul 16, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@3TUSK
Copy link

3TUSK commented Jul 16, 2023

Title.

This idea comes into my mind when I see the prompt dialog that asks me to choose one of three: update, keep current or cancel launch.

Ideally, this window should not pop up when the pack is stable - I saw that window because I was using our nightly builds, which updates periodically. Still, having a translated GUI makes our audiences easier to understand what is going on.
Further, there is also this "Optional mods..." button. For now, we did not make a use of it. Should we make a use of it in the future, it would be nice to see a translated version here.

To determine the language to use, you can use either System.getProperty("user.language") or java.util.Locale.getDefault(). This queries the system locale, which should be your best bet.

You can consider leveraging java.util.ResourceBundle to implement language files. AFAIK, Fabric loader and Fabric-installer use it.

@comp500 comp500 added the enhancement New feature or request label Jul 16, 2023
@comp500
Copy link
Member

comp500 commented Jul 16, 2023

(related issue: packwiz/packwiz#22)
Do you recommend a localisation platform (e.g. Weblate/Crowdin/etc) to manage these translations? I would be happy to implement i18n support, although it may take a while to convert the existing hardcoded strings (particularly for the CLI, though that isn't as important as packwiz-installer).

@3TUSK
Copy link
Author

3TUSK commented Jul 16, 2023

Do you recommend a localisation platform (e.g. Weblate/Crowdin/etc) to manage these translations?

I won't recommend a dedicated platform until there are too many languages, or unless you don't want translation PRs to clutter your git history.

I don't have a particular platform to recommend:

  • Crowdin has free tier for open-source projects. Some notable users include Forge itself, SpongeDocs, Twilight Forest, Mekanism, The Aether, etc. However, to my knowledge, Crowdin cannot be self-hosted.
  • Weblate does not offer free tier plan, but Weblate itself is FLOSS and thus can be self-hosted. A notable example of self-hosting Weblate is CFPA's MMLP, which offers nearly comprehensive Chinese translations for mainstream mods.
  • There is also Transifix; similar to Weblate, it does not have free-tier plan. Not sure who is still using it.

@zbx1425
Copy link

zbx1425 commented Jan 20, 2024

Oof, I should've checked the issue list before jumping into #73
But anyways #73 is about converting some of these existing hardcoded strings into language files, albeit probably not very nicely; as for online platform, IMO there'd always be the option of allowing people to submit, but only merge in the contents manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants