Skip to content

Commit 8dfda45

Browse files
committed
Table: Screen reader usage for header cells
This changes the screen reader usage in table header cells to use the prop instead of the classname itself for consistency and potential CSS issues.
1 parent c4dc93d commit 8dfda45

File tree

8 files changed

+8
-24
lines changed

8 files changed

+8
-24
lines changed

frontend/src/components/bodhi/BodhiUpdatesTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ const BodhiUpdatesTable = () => {
4949
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
5050

5151
const TableHeads = [
52-
<Th key={columnNames.forge}>
53-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
54-
</Th>,
52+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
5553
<Th key={columnNames.trigger} width={35}>
5654
{columnNames.trigger}
5755
</Th>,

frontend/src/components/copr/CoprBuildsTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@ const CoprBuildsTable = () => {
6969
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
7070

7171
const TableHeads = [
72-
<Th key={columnNames.forge}>
73-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
74-
</Th>,
72+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
7573
<Th key={columnNames.trigger} width={15}>
7674
{columnNames.trigger}
7775
</Th>,

frontend/src/components/koji/KojiBuildsTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ export const KojiBuildsTable: React.FC<KojiBuildTableProps> = ({ scratch }) => {
4545
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
4646

4747
const TableHeads = [
48-
<Th key={columnNames.forge}>
49-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
50-
</Th>,
48+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
5149
<Th key={columnNames.trigger} width={35}>
5250
{columnNames.trigger}
5351
</Th>,

frontend/src/components/koji/KojiTagRequestsTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ export const KojiTagRequestsTable = () => {
4444
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
4545

4646
const TableHeads = [
47-
<Th key={columnNames.forge}>
48-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
49-
</Th>,
47+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
5048
<Th key={columnNames.trigger} width={20}>
5149
{columnNames.trigger}
5250
</Th>,

frontend/src/components/osh/OSHScansTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,7 @@ const OSHScansTable = () => {
5050
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
5151

5252
const TableHeads = [
53-
<Th key={columnNames.forge}>
54-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
55-
</Th>,
53+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
5654
<Th key={columnNames.trigger} width={35}>
5755
{columnNames.trigger}
5856
</Th>,

frontend/src/components/srpm/SRPMBuildsTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ export const SRPMBuildsTable = () => {
4545
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
4646

4747
const TableHeads = [
48-
<Th key={columnNames.forge}>
49-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
50-
</Th>,
48+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
5149
<Th key={columnNames.trigger} width={50}>
5250
{columnNames.trigger}
5351
</Th>,

frontend/src/components/sync-release/SyncReleasesTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ export const SyncReleasesTable: React.FC<SyncReleasesTableProps> = ({
4949
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
5050

5151
const TableHeads = [
52-
<Th key={columnNames.forge}>
53-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
54-
</Th>,
52+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
5553
<Th key={columnNames.trigger} width={25}>
5654
{columnNames.trigger}
5755
</Th>,

frontend/src/components/testing-farm/TestingFarmRunsTable.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,7 @@ export const TestingFarmRunsTable = () => {
4646
const rows = useMemo(() => (data ? data.pages.flat() : []), [data]);
4747

4848
const TableHeads = [
49-
<Th key={columnNames.forge}>
50-
<span className="pf-v6-u-screen-reader">{columnNames.forge}</span>
51-
</Th>,
49+
<Th key={columnNames.forge} screenReaderText={columnNames.forge}></Th>,
5250
<Th key={columnNames.trigger} width={35}>
5351
{columnNames.trigger}
5452
</Th>,

0 commit comments

Comments
 (0)