Rewrite 2 of tests.md #752
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowalleck
reviewed
Nov 21, 2025
Member
Author
|
@jkowalleck Pushed changes resolving your comments - thanks for the review. |
pombredanne
reviewed
Dec 2, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Here are some partial comments.
pombredanne
reviewed
Dec 3, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Here is second set of reviews! 👍
| - The proposed change for validation messages allows multiple messages from a | ||
| single test case. | ||
| - There is no message returned for a successful validation. | ||
| - We will need to clearly define the difference between an info message and a |
| >*Error message discussion* | ||
| The current PURL specification documentation does not contain guidance |
Member
There was a problem hiding this comment.
OK, but then we should at least link to existing implementations
| There is also an important perspective from [PR 747](https://github.com/package-url/purl-spec/pull/747) | ||
| regarding the expected use of PURL test messages by PURL tools. | ||
|
|
||
| *"I don't think it is necessary or beneficial for PURL to specify error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the draft from: