Skip to content

Conversation

@booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Sep 17, 2025

Closes:

Clashes a little with a different approach at #671 since this will consider the VS Code extension marketplace as the default repository

I think we're aligned on this now

The type vsx refers to "VS code eXtension" and seems to be used in multiple places. Open to alternatives like vscode. As a note, the file extension for these IDE extension packages is .vsix.

After discussion, the PR now proposes the type vscode. The previous suggestion of vsx is ambiguous as it could refer to either VS Code extensions (JS) or to Visual Studio extensions (C#) which are incompatible. (Refer to this comment thread)

Happy to hear & take feedback, thanks!

@booniepepper booniepepper force-pushed the add-vscode-extensions branch 2 times, most recently from 7958fe9 to 65fe416 Compare September 17, 2025 14:47
@jkowalleck jkowalleck mentioned this pull request Sep 18, 2025
@booniepepper
Copy link
Contributor Author

@jkowalleck Any thoughts on this?

@mixmix
Copy link

mixmix commented Sep 24, 2025

As I raised here : #671 (comment) , I'm really interested in how we keep consumers of PURLs safe from things like typosquat attacks. Some context is I work in security and have had a client ask me to review an extension giving just it's name ... and it was really hard to answer their question because I did not know which code I was meant to be auditing! (because there are two registries and they can have different code).

To that end I'm against vsx because I'm scared of it being a foot-gun. I think vscode would be a lot safer.

I think we should explore the question of how we handle referencing extensions in these two registries before merging these PRs though. Propose we continue discussion in that other PR (it's got a bit of discussion already)

@booniepepper
Copy link
Contributor Author

I have examples in the PR. I think it's easy to distinguish the source by repository_url and this follows the convention used in many other PURL specs.

P.S. I incorporated your changes and credited you in one of the commits included in this PR

P.P.S. I've also been working on software supply chain security for much of the past 5 years

@mixmix
Copy link

mixmix commented Sep 26, 2025

Update: after some great input from community, have opted to close #671 in favour of this proposal ❤️

@amvanbaren
Copy link

Hi! I don't know why, but I got notified about this issue. Any way I can help?

@booniepepper
Copy link
Contributor Author

booniepepper commented Oct 7, 2025

@amvanbaren The PR was waiting on me to update (which I have now) -- I'm not sure either, but the more eyes the merrier

Copy link

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, really appreciate the depth of everyones attention to detail, listening, and thoughtful dialogue. I think we've come to something which is better than any one of alone would have suggesting 🌈 🚀

@booniepepper booniepepper force-pushed the add-vscode-extensions branch from 07a7a75 to 59afa0a Compare October 9, 2025 17:23
@booniepepper booniepepper requested review from mixmix and rhalar October 9, 2025 17:26
@booniepepper booniepepper force-pushed the add-vscode-extensions branch from 59afa0a to 0b9bf69 Compare October 14, 2025 05:11
@booniepepper booniepepper requested a review from rhalar October 14, 2025 05:11
@booniepepper booniepepper force-pushed the add-vscode-extensions branch from 0b9bf69 to 8bb58fd Compare October 15, 2025 20:00
@booniepepper booniepepper requested a review from rhalar October 15, 2025 20:01
@booniepepper
Copy link
Contributor Author

@pombredanne Looks like we've got all the comments addressed. Are you ready to take a look again?

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants