-
Notifications
You must be signed in to change notification settings - Fork 213
Add VS Code extensions #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7958fe9 to
65fe416
Compare
|
@jkowalleck Any thoughts on this? |
|
As I raised here : #671 (comment) , I'm really interested in how we keep consumers of PURLs safe from things like typosquat attacks. Some context is I work in security and have had a client ask me to review an extension giving just it's name ... and it was really hard to answer their question because I did not know which code I was meant to be auditing! (because there are two registries and they can have different code). To that end I'm against I think we should explore the question of how we handle referencing extensions in these two registries before merging these PRs though. Propose we continue discussion in that other PR (it's got a bit of discussion already) |
|
I have examples in the PR. I think it's easy to distinguish the source by P.S. I incorporated your changes and credited you in one of the commits included in this PR P.P.S. I've also been working on software supply chain security for much of the past 5 years |
|
Update: after some great input from community, have opted to close #671 in favour of this proposal ❤️ |
|
Hi! I don't know why, but I got notified about this issue. Any way I can help? |
ac6819f to
07a7a75
Compare
|
@amvanbaren The PR was waiting on me to update (which I have now) -- I'm not sure either, but the more eyes the merrier |
mixmix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, really appreciate the depth of everyones attention to detail, listening, and thoughtful dialogue. I think we've come to something which is better than any one of alone would have suggesting 🌈 🚀
07a7a75 to
59afa0a
Compare
59afa0a to
0b9bf69
Compare
0b9bf69 to
8bb58fd
Compare
|
@pombredanne Looks like we've got all the comments addressed. Are you ready to take a look again? |
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes:
Clashes a little with a different approach at #671 since this will consider the VS Code extension marketplace as the default repositoryI think we're aligned on this now
The typevsxrefers to "VS code eXtension" and seems to be used in multiple places. Open to alternatives likevscode. As a note, the file extension for these IDE extension packages is.vsix.After discussion, the PR now proposes the type
vscode. The previous suggestion ofvsxis ambiguous as it could refer to either VS Code extensions (JS) or to Visual Studio extensions (C#) which are incompatible. (Refer to this comment thread)Happy to hear & take feedback, thanks!