Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken URL encoding and decoding for Cyrillic characters #154

Open
nscuro opened this issue Feb 10, 2025 · 0 comments · May be fixed by #160
Open

Broken URL encoding and decoding for Cyrillic characters #154

nscuro opened this issue Feb 10, 2025 · 0 comments · May be fixed by #160

Comments

@nscuro
Copy link

nscuro commented Feb 10, 2025

Parsing the following PURL with URL-encoded Cyrillic characters (e.g. %D0%9C for the Cyrillic M):

pkg:nuget/%D0%9Circos%D0%BEft.%D0%95ntit%D1%83Fram%D0%B5work%D0%A1%D0%BEr%D0%B5

Yields the following PURL when calling PackageURL#toString:

pkg:nuget/%FFFFFFC3%FFFFFF90%FFFFFFC2%FFFFFF9Circos%FFFFFFC3%FFFFFF90%FFFFFFC2%FFFFFFBEft.%FFFFFFC3%FFFFFF90%FFFFFFC2%FFFFFF95ntit%FFFFFFC3%FFFFFF91%FFFFFFC2%FFFFFF83Fram%FFFFFFC3%FFFFFF90%FFFFFFC2%FFFFFFB5work%FFFFFFC3%FFFFFF90%FFFFFFC2%FFFFFFA1%FFFFFFC3%FFFFFF90%FFFFFFC2%FFFFFFBEr%FFFFFFC3%FFFFFF90%FFFFFFC2%FFFFFFB5
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Feb 20, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Feb 20, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Feb 20, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Feb 20, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Feb 20, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Feb 20, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Feb 20, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
@dwalluck dwalluck linked a pull request Feb 20, 2025 that will close this issue
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 10, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 11, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 12, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 13, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
dwalluck added a commit to dwalluck/packageurl-java that referenced this issue Mar 14, 2025
The methods `uriEncode` and `uriDecode` did not properly handle
percent-encoding. In particular, `uriEncode` didn't properly output two
uppercase hex digits and `urlDecode` did not properly handle non-ASCII
characters.

Aditionally, if no percent-encoding was performed, these methods will
now return the original string.

Fixes package-url#150
Closes package-url#153
Fixes package-url#154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant