Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should LZ5 be removed? #125

Closed
wdlkmpx opened this issue Mar 18, 2021 · 3 comments
Closed

Should LZ5 be removed? #125

wdlkmpx opened this issue Mar 18, 2021 · 3 comments

Comments

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Mar 18, 2021

https://github.com/inikep/lz5/ redirects to https://github.com/inikep/lizard

So Lizard is LZ5 with bugfixes ( inikep/lizard#28 )

It really doesn't make sense to keep LZ5, unless it's a version incompatible with Lizard...

If Lizard can decompress LZ5, then the lz5 compressor and decompressor should be removed, otherwise only the lz5 compressor should be removed,

But reading a bit more: Lizard = LZ5 = LZ4 ??? Apparently LZ4 is the format and LZ5/Lizard is just an improved compressor. Hmmm

@wdlkmpx
Copy link
Contributor Author

wdlkmpx commented Mar 18, 2021

So LZ5 and Lizard are incompatible, now it makes sense...

I performed some quick tests lz4 vs lz5 ...

# time ./lz4 -9 snes9x.exe
Compressed filename will be : snes9x.exe.lz4 
Compressed 6268416 bytes into 2493452 bytes ==> 39.78%                         

real	0m0.406s
user	0m0.383s
sys	0m0.023s


# time ./lz5 -15 snes9x.exe
Compressed filename will be : snes9x.exe.lz5 
Compressed 6268416 bytes into 2165834 bytes ==> 34.55%                         

real	0m4.871s
user	0m4.150s
sys	0m0.703s

lz4 is incredibly fast, and basically produces the same compression with equivalent cmp levels
lz4 -3 vs lz5 -> lz4 produces smaller files with the same speed

lz5 -15 is incredibly slow and doesn't seem to produce files smaller than gzip's
and gzip is as fast as lz4 -9

@wdlkmpx
Copy link
Contributor Author

wdlkmpx commented Mar 18, 2021

My quick humble non-scientific tests suggest that lz5 is not better than lz4 in any way, so in order to simplify the codebase a bit, to get faster compile times, less things to worry about, etc, these are actions that should be taken:

  1. lizard releases a new version with lz5 v1.5 decompression support
  2. lz5 is removed from p7zip
  3. p7zip: only lz5 decompression is supported through lizard

but I'll close this because that won't happen.

@wdlkmpx wdlkmpx closed this as completed Mar 18, 2021
@alicektx
Copy link
Contributor

...it also looks that...considering it has barely seen a couple of maintenance commits since 2017,
i'd personally stay with lz4, zstd & brotli (google & facebook...
ie. extensive security testing & not only etc etc)... ¯_(ツ)_/¯

GerHobbelt pushed a commit to GerHobbelt/p7zip that referenced this issue Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants