Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc / ebpf backends use unparsed annotations #5021

Open
asl opened this issue Nov 19, 2024 · 1 comment
Open

tc / ebpf backends use unparsed annotations #5021

asl opened this issue Nov 19, 2024 · 1 comment
Labels
ebpf Topics related to the eBPF back end p4tc Topics related to the P4-TC back end

Comments

@asl
Copy link
Contributor

asl commented Nov 19, 2024 •
edited
Loading

There should never be unparsed annotations actually used in the compiler -- it is just a matter of adding one PARSE_type line to parseAnnotations.cpp (or in a backend file). This is related to the mess that is "structured" annotations -- all annotations are structured -- it is just that some people didn't want to enumerate all the annotations in parseAnnotations.cpp as that was too hard to maintain.

Originally posted by @ChrisDodd in #5018 (comment)
@asl asl added ebpf Topics related to the eBPF back end p4tc Topics related to the P4-TC back end labels Nov 19, 2024
@asl
Copy link
Contributor Author

asl commented Nov 19, 2024

See https://github.com/p4lang/p4c/pull/5018/files#diff-2494735621545235a407b7a74124268ece6ec99bc8f55a5a581675771e3c0114R208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ebpf Topics related to the eBPF back end p4tc Topics related to the P4-TC back end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asl