diff --git a/.golangci.yml b/.golangci.yml new file mode 100644 index 0000000..695f43b --- /dev/null +++ b/.golangci.yml @@ -0,0 +1,8 @@ +linters: + # https://golangci-lint.run/usage/linters/#enabled-by-default + enable: + - goconst + - gocritic + - gosec + - nilnil + - revive diff --git a/config.go b/config.go index 1029622..b9fa523 100644 --- a/config.go +++ b/config.go @@ -60,7 +60,7 @@ func ReadConfig() (*Config, error) { return nil, err } - err = os.WriteFile(fileName, defaultMarshalled, 0644) + err = os.WriteFile(fileName, defaultMarshalled, 0600) if err != nil { return nil, err } diff --git a/main.go b/main.go index 77325d3..fbf098c 100644 --- a/main.go +++ b/main.go @@ -9,13 +9,15 @@ import ( func main() { conn, err := dbus.ConnectSessionBus() if err != nil { - log.Fatalf("failed to connect to session bus: %v", err) + log.Printf("failed to connect to session bus: %v", err) + return } defer conn.Close() config, err := ReadConfig() if err != nil { - log.Fatalf("error reading config: %v", err) + log.Printf("error reading config: %v", err) + return } RunMainLoop(conn, config) diff --git a/mpris.go b/mpris.go index c39d670..2981c02 100644 --- a/mpris.go +++ b/mpris.go @@ -93,9 +93,8 @@ func getProperty[E any](obj dbus.BusObject, property string) (*E, error) { if parsedValue, ok := value.Value().(E); ok { return &parsedValue, nil - } else { - return nil, errors.New("failed to read property from DBus object") } + return nil, errors.New("failed to read property from DBus object") } func getMapEntry[E any](metadata map[string]dbus.Variant, key string) (*E, error) { @@ -106,7 +105,6 @@ func getMapEntry[E any](metadata map[string]dbus.Variant, key string) (*E, error if parsedValue, ok := value.Value().(E); ok { return &parsedValue, nil - } else { - return nil, fmt.Errorf("invalid data type for map entry %s", key) } + return nil, fmt.Errorf("invalid data type for map entry %s", key) } diff --git a/provider_file.go b/provider_file.go index 0e79bed..f9b78f2 100644 --- a/provider_file.go +++ b/provider_file.go @@ -9,7 +9,7 @@ import ( "time" ) -func (f *FileConfig) NowPlaying(n NowPlaying) { +func (f *FileConfig) NowPlaying(_ NowPlaying) { }