Skip to content

Commit 772f3b3

Browse files
committed
fix: always allow providers
1 parent 641d104 commit 772f3b3

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

pkg/ocm/provider/authorizer/json/json.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,12 @@ func (a *authorizer) IsProviderAllowed(ctx context.Context, pi *ocmprovider.Prov
173173
}
174174

175175
switch {
176-
case !providerAuthorized:
177-
return errtypes.NotFound(pi.GetDomain())
178176
case !a.conf.VerifyRequestHostname:
177+
log.Info().Msg("VerifyRequestHostname is disabled. any provider is allowed")
179178
return nil
179+
case !providerAuthorized:
180+
log.Info().Msg("providerAuthorized is false")
181+
return errtypes.NotFound(pi.GetDomain())
180182
case len(pi.Services) == 0:
181183
return ErrNoIP
182184
}

pkg/ocm/provider/authorizer/json/json_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ func TestAuthorizer_IsProviderAllowed(t *testing.T) {
4949
providerInfo: &ocmprovider.ProviderInfo{
5050
Domain: "some.unknown.domain",
5151
},
52-
expectedError: errtypes.NotFound("some.unknown.domain"),
52+
verifyRequestHostname: true,
53+
expectedError: errtypes.NotFound("some.unknown.domain"),
5354
},
5455
"authorized without host name verification": {
5556
providerInfo: &ocmprovider.ProviderInfo{
@@ -65,7 +66,8 @@ func TestAuthorizer_IsProviderAllowed(t *testing.T) {
6566
providerInfo: &ocmprovider.ProviderInfo{
6667
Domain: "server-two",
6768
},
68-
expectedError: error(errtypes.NotFound("server-two")),
69+
verifyRequestHostname: true,
70+
expectedError: error(errtypes.NotFound("server-two")),
6971
},
7072
} {
7173
t.Run(name, func(t *testing.T) {

0 commit comments

Comments
 (0)