Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert change that skip arm64 image build #47

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Faraz32123
Copy link
Collaborator

- As didkit issue is resolved in latest version which is being used in
upstream credential repo. So, reverting this change.
for context, see this comment: #34 (comment)
@Faraz32123 Faraz32123 self-assigned this Oct 10, 2024
Copy link
Collaborator

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! You want to make a new release to try out the arm64 CI pipeline? When you do, you'll realize that we need a changelog entry, so we might just as well add one here, despite the fact that it's "just" a CI change.

@DawoudSheraz
Copy link
Contributor

The upstream fix (via requirements upgrade) was merged into master and not backported to redwood.master. Therefore, only the nightly build is working. The master build is still broken. We have 2 options here:

@Faraz32123
Copy link
Collaborator Author

The upstream fix (via requirements upgrade) was merged into master and not backported to redwood.master. Therefore, only the nightly build is working. The master build is still broken. We have 2 options here:

I have created the backport PR. So that it can work with redwood.

@DawoudSheraz
Copy link
Contributor

The upstream fix (via requirements upgrade) was merged into master and not backported to redwood.master. Therefore, only the nightly build is working. The master build is still broken. We have 2 options here:

I have created the backport PR. So that it can work with redwood.

I realized later that merging to redwood.master is not enough. We would need to wait for redwood.3 tag to be available for the build to pass. I am not sure if Axim has redwood.3 tag planned in near future.

@Faraz32123
Copy link
Collaborator Author

I think we can merge this change in nightly then.

@cmltaWt0
Copy link
Contributor

The upstream fix (via requirements upgrade) was merged into master and not backported to redwood.master. Therefore, only the nightly build is working. The master build is still broken. We have 2 options here:

I have created the backport PR. So that it can work with redwood.

I realized later that merging to redwood.master is not enough. We would need to wait for redwood.3 tag to be available for the build to pass. I am not sure if Axim has redwood.3 tag planned in near future.

The release of redwood.3 is planned for 23 Oct.

@Faraz32123 Faraz32123 changed the base branch from master to nightly October 21, 2024 07:23
@Faraz32123 Faraz32123 force-pushed the chore/revert_arm64_build_skip_change branch from 78c80be to 7a44277 Compare October 21, 2024 07:27
@Faraz32123
Copy link
Collaborator Author

We'll be merging back this feature in sumac in favor of this info.

@Faraz32123 Faraz32123 merged commit 19140cc into nightly Oct 21, 2024
2 checks passed
@Faraz32123 Faraz32123 deleted the chore/revert_arm64_build_skip_change branch October 21, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants