Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screensharing issue #69

Closed
aacebedo opened this issue Feb 11, 2024 · 7 comments
Closed

Screensharing issue #69

aacebedo opened this issue Feb 11, 2024 · 7 comments

Comments

@aacebedo
Copy link

Hi,

I am not 100% sure yet, but I think that hy3 causes a problem with screensharing of tabbed windows and hyprland portal.

If I try to share a non-focused tabbed window using https://mozilla.github.io/webrtc-landing/gum_test.html, I end up with a blank screen. This does not happen if the window is visible when I start sharing, but it freezes if I tab the window that is currently shared.

I am using hyprland, hy3 0.34 and xdg-desktop-portal-hyprland 1.3.1 on NixOS.

Anyone can reproduce?

@Mange
Copy link

Mange commented Feb 12, 2024

Seems to be the same effect for me.

Note that window sharing always fails for me except for the first share after a Portal restart, so my reproduction was basically this:

  1. Restart portal
  2. Try to share window $window.
  3. Wait for preview to come up in my browser.
Case Outcome
Visible non-tabbed window Works
Visible tabbed window Works after some time, most of the times
Tabbed window that is not focused No preview response, not even black screen
> hyprctl version
Hyprland, built from branch  at commit 4f804d5f962070c531dea5025e61be8a0da8129e  ().
Date: 2024-01-31

# plugin=/nix/store/xp15haqh2pkwa48p187mncdqq5108cw3-hy3-0.1/lib/libhy3.so

@outfoxxed
Copy link
Owner

So what happens if you do the same thing on a normal hyprland group? We do roughly the same thing in hy3 that hyprland does with hidden windows in a group.

@aacebedo
Copy link
Author

So what happens if you do the same thing on a normal hyprland group? We do roughly the same thing in hy3 that hyprland does with hidden windows in a group.

Tried grouped window, and it seems to have the same problem. So it may be related to hyprland. I opened a bug here hyprwm/xdg-desktop-portal-hyprland#179. Depending on the response, I'll close this one.

@outfoxxed
Copy link
Owner

Alright let me know if its not just a hyprland issue

@sleroq
Copy link

sleroq commented Feb 3, 2025

Screensharing a window works on Hyprland 0.47.0. Maybe it's solved.

Also tested with Discord Canary.

@Mange
Copy link

Mange commented Feb 3, 2025

Screensharing a window works on Hyprland 0.47.0. Maybe it's solved.

Also tested with Discord Canary.

This issue is about about tabbed windows. Did you test that?


I decided to test myself now to help triage. I used WebRTC samples - getDisplayMedia to test this in my browser.

  1. I opened multiple windows in a tabbed container.
  2. I screenshared "A window" and picked one of the windows that were not shown in the tabbed container, i.e. an unfocused backgrounded tab.
  3. Window appeared immediately in screenshare. I could swap around focus in the tabbed group and it remained working, no matter which window was shown on my screen.

I think this issue can be closed.

$ hyprctl version
Hyprland 0.47.1 built from branch v0.47.1-b at commit 75dff7205f6d2bd437abfb4196f700abee92581a  (version: bump to 0.47.1).
Date: 2025-01-29
Tag: v0.47.1, commits: 75dff7205f6d2bd437abfb4196f700abee92581a
built against:
 aquamarine 0.7.2
 hyprlang 0.6.0
 hyprutils 0.5.0
 hyprcursor 0.1.11
 hyprgraphics 0.1.1


no flags were set
$ rg hy3 ~/.config/hypr/hyprland.conf
2:plugin=/nix/store/ay580zqynvd57yc2v6pcjpj5qchxdp91-hy3-0.47.0/lib/libhy3.so

@outfoxxed
Copy link
Owner

Was likely fixed with hyprwm/Hyprland#9041. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants