Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move vip to lua #4823

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Move vip to lua #4823

wants to merge 14 commits into from

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Nov 4, 2024 •
edited
Loading

Pull Request Prelude

Changes Proposed

  • Rewrite the VIP system in Lua

image
image
image

@ramon-bernardo ramon-bernardo marked this pull request as ready for review November 4, 2024 23:18
@Shawak
Copy link
Contributor

Shawak commented Nov 5, 2024

With that rewrite wont you get notified about players which are in ghost mode while before you weren't?

@ramon-bernardo
Copy link
Contributor Author

With that rewrite wont you get notified about players which are in ghost mode while before you weren't?

Unfortunately, no, I'm thinking of an alternative... we currently don't have an event for ghost_mode changes

@ramon-bernardo
Revert "Fix import order"
be472f5 
This reverts commit a287bdd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt Awaiting requested review from ranisalt

@EvilHero90 EvilHero90 Awaiting requested review from EvilHero90

@nekiro nekiro Awaiting requested review from nekiro

@MillhioreBT MillhioreBT Awaiting requested review from MillhioreBT

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon-bernardo @Shawak