Fix Monster Look Direction Behavior #4785
Conversation
EPuncker
requested review from
ranisalt,
EvilHero90,
nekiro and
MillhioreBT
|
Screencast from RL, fleeing sheep will always look in the direction it's fleeing, never looks back at player: Screencast.from.2024-09-16.01-34-01.webmHowever, if the creature is fleeing AND decides to attack player (i.e. Dragon running in low health) with a directioned attack (a wave), it will direct the attack towards the player. It turns to the player for a split second only to wave, and then will continue fleeing. |
perhaps we should make it work only with creatures that have aggressive flag? |
|
I have an idea to get it working. Working on it now. It seems rl probably has monsters check if they can attack once they finish their walk. @ranisalt do you know if it is possible for monster on rl to cast without updating their look direction sometimes? |
|
So after checking RL. The monsters look like they are having spasms with how fast they turn.... I guess I need to make my code look even more messed up lol. |
|
Alright I think this looks even better than rl. Ranged monster also behave the same way as fleeing as shown in the video. |
|
Alright, LGTM |
| updateLookDirection(); | ||
| lookUpdated = true; | ||
| lastStep = OTSYS_TIME() - 200; |
There was a problem hiding this comment.
This made the sheep extremely slow 🐢
Pull Request Prelude
Changes Proposed
Allow monsters to update their look direction even if they cannot attack.
Stop fleeing monsters from updating their look direction.
As of now monsters will not update their look direction if they cannot attack (rl they do)
As of now fleeing monsters will look at the player randomly (rl they do not)
I can't figure out how to record rl so if someone can tell me, otherwise I can't get a video of it.
Issues addressed:
closes #4339