[Bug]: using interval with onTime no longer work

[Sajgon]

By submitting this bug issue, you agree to the following.

• This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
• This issue is reproducible without changes to the C++ code in this repository
• This bug has not been resolved in master branch
• There is no existing issue for this bug already

Does this bug crash tfs?

no

Server Version

1.7 (Master)

Operation System

all (listed below)

OS Description

No response

Bug description

using interval with onTime no longer work

Possible Pull Requests which are to blame

• # 46e2b7a#diff-9cab8e66cea1067bf36772fb84b9bbd73f55b26137be07de21c9cf046d028870R240

Steps to reproduce

Example:

1. In the script world_light.lua see the value of interval (10000), which equals to 10 seconds
2. The script should run every 10 seconds, but isn't
3. The reason is because onTime has a type in compat.lua, the interval isn't set. See the code below, if type is used interval isn't.

} else if ((attr = node.attribute("type"))) {
		const char* value = attr.value();
		if (caseInsensitiveEqual(value, "startup")) {
			eventType = GLOBALEVENT_STARTUP;
		} else if (caseInsensitiveEqual(value, "shutdown")) {
			eventType = GLOBALEVENT_SHUTDOWN;
		} else if (caseInsensitiveEqual(value, "record")) {
			eventType = GLOBALEVENT_RECORD;
		} else if (caseInsensitiveEqual(value, "save")) {
			eventType = GLOBALEVENT_SAVE;
		} else {
			std::cout << "[Error - GlobalEvent::configureEvent] No valid type \"" << attr.as_string()
			          << "\" for globalevent with name " << name << std::endl;
			return false;
		}
	} else if ((attr = node.attribute("interval"))) {
		interval = std::max<int32_t>(SCHEDULER_MINTICKS, pugi::cast<int32_t>(attr.value()));
		nextExecution = OTSYS_TIME() + interval;
	} 

Code to reproduce the issue:

function event.onTime(interval)
	console.log("🚀 ~ WorldLight onTime:", onTime)
	if not defaultWorldLight then
		return true
	end

	local worldLightColor, worldLightLevel = Game.getWorldLight()
	local level = calculateWorldLightLevel()
	Game.setWorldLight(worldLightColor, level)
	return true
end

event:interval(10000) -- 10 seconds
event:register()

Actual Behavior

The script is only ran once on startup.

Expected Behavior

The script should run every 10 seconds.

Backtrace

No response