Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Lua 5.4 breaking compatibility #4827

Closed
4 tasks done
ArturKnopik opened this issue Nov 7, 2024 · 1 comment
Closed
4 tasks done

[Bug]: Lua 5.4 breaking compatibility #4827

ArturKnopik opened this issue Nov 7, 2024 · 1 comment
Labels
bug An issue describing unexpected behavior of code priority: medium

Comments

@ArturKnopik
Copy link
Contributor

ArturKnopik commented Nov 7, 2024

By submitting this bug issue, you agree to the following.

  • This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository
  • This bug has not been resolved in master branch
  • There is no existing issue for this bug already

Does this bug crash tfs?

no

Server Version

1.7 (Master)

Operation System

Windows

OS Description

No response

Bug description

lua_pushnumber for lua 5.4 is pushing double when luajit is using int

Possible Pull Requests which are to blame

No response

Steps to reproduce

Setup project using manifest file on windows
try buy items from npc

try print values registred by registerEnum (ex: print(WEAPON_CLUB))

Actual Behavior

image

ints are treated as float/double

print(WEAPON_CLUB) = 2.0

Expected Behavior

ints should be treated as ints

print(WEAPON_CLUB) = 2

Backtrace

No response

@ArturKnopik ArturKnopik added bug An issue describing unexpected behavior of code needs-confirmation not confirmed by a developer yet labels Nov 7, 2024
@github-project-automation github-project-automation bot moved this to Backlog in TFS 1.8 Nov 7, 2024
@EPuncker EPuncker added priority: medium and removed needs-confirmation not confirmed by a developer yet labels Nov 8, 2024
@ArturKnopik
Copy link
Contributor Author

Duplicated issue
The first one here:
#4522

@github-project-automation github-project-automation bot moved this from Backlog to Done in TFS 1.8 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected behavior of code priority: medium
Projects
Status: Done
Development

No branches or pull requests

2 participants