New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[smartaccount] Cache the authentication request for using in post handler #8371

Open

PaddyMc opened this issue Jun 11, 2024 · 0 comments

Collaborator

PaddyMc commented Jun 11, 2024

Background

Currently we call the [GenerateAuthenticationRequest](https://github.com/osmosis-labs/osmosis/blob/main/x/smart-account/authenticator/authentication_request.go#L202] twice:

Suggested Design

Write a cache for the authentication request
Use the cached version of the authentication request in the post handler

Acceptance Criteria

Cache works as expected
Improved test coverage
benchmark results to be sure

osmo-bot added this to Osmosis Chain Development

github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development

PaddyMc mentioned this issue

fix: remove some todos #8354

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment