-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Chain Router #8235
Comments
Hey @czarcas7ic, I was wondering what's left to implement ( based on work on #6930 ) it's just to review a comments and make relevant requested changes or there is something more involving in terms of logic it self? |
I think its just a matter of having the time to open again with full proper tests. The primary concern with this feature is ensuring it is performant (i.e. benchmarking the toll this takes on epoch, as well as benching the query itself) I think its not far off from where it needs to be, its just there are currently other priorities that are higher than this feature, but this feature is still important. Not sure if you are mentioning because you want to give it a try, if so, feel free to cherry-pick and pick up work from where it was left off. Its currently sitting at number 3 in my queue of features to work on. |
Got it, thanks! I was considering picking this up, however I have already started work on other task. Let me ping you in case I manage to get back to this one before you resume on it or somebody else takes it. |
Background
Right now, we utilize skips hot routes as a make shift router to swap tokens during epoch. Skip lacks many routes (as it does not fit their specific use case), so we get tokens stuck in module accounts due to a lack of routes to swap through.
This is just one use case, there are plenty of other reasons why someone would want a basic router to get from token A to token B, without any advanced split routing / guarantees that it is the best route.
Suggested Design
#6930
Acceptance Criteria
Router implemented and queryable, but not utilized in any stateful transactions.
The text was updated successfully, but these errors were encountered: