From c3a14b195b9be06e653d4c362be862dd53edd704 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 27 Feb 2024 20:53:51 +0000 Subject: [PATCH] Generate email change token before changing the address --- app/controllers/concerns/user_methods.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/controllers/concerns/user_methods.rb b/app/controllers/concerns/user_methods.rb index 8cba098272..28305b5c3d 100644 --- a/app/controllers/concerns/user_methods.rb +++ b/app/controllers/concerns/user_methods.rb @@ -45,13 +45,15 @@ def update_user(user, params) if user.new_email.blank? || user.new_email == user.email flash[:notice] = t "accounts.update.success" else + token = user.generate_token_for(:new_email) + user.email = user.new_email if user.valid? flash[:notice] = t "accounts.update.success_confirm_needed" begin - UserMailer.email_confirm(user, user.generate_token_for(:new_email)).deliver_later + UserMailer.email_confirm(user, token).deliver_later rescue StandardError # Ignore errors sending email end