Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include preserveTags in nsi-id-presets.json #10083

Open
westnordost opened this issue Oct 25, 2024 · 3 comments
Open

Include preserveTags in nsi-id-presets.json #10083

westnordost opened this issue Oct 25, 2024 · 3 comments
Labels
chore enhancement Actionable - add an enhancement to the source code javascript Pull requests that update Javascript code

Comments

@westnordost
Copy link
Contributor

Currently, the preserveTags property is only added to the presets in dist/nsi.json but not to the presets in dist/presets/nsi-id-presets.json.

Since this property should trigger a change in behavior how the preset from the NSI is applied, it should be included in the nsi-id-presets.json, too, even if that property is not mentioned in the schema for presets.

I am using the nsi-id-presets.json in StreetComplete (via the osmfeatures library). It is convenient for me to use these because they are in the same format as the iD presets.

@Snowysauce Snowysauce added the enhancement Actionable - add an enhancement to the source code label Oct 26, 2024
@UKChris-osm
Copy link
Collaborator

Does iD not used dist/presets/nsi-id-presets.json?

Could StreetComplete not use dist/nsi.json if this file already includes the preserveTags data? That file seems a lot smaller as well.

@UKChris-osm UKChris-osm added chore javascript Pull requests that update Javascript code labels Oct 27, 2024
@westnordost
Copy link
Contributor Author

Could StreetComplete not use dist/nsi.json if this file already includes the preserveTags data? That file seems a lot smaller as well.

It is more convenient to use nsi-id-presets.json as it is in the same format as the iD presets and thus does not require to write another parser for that.

@bhousel
Copy link
Member

bhousel commented Oct 30, 2024

Yeah we can probably do this..

For what it's worth, I'm kind of considering the nsi-id-presets file a bit of a legacy file.
In Rapid (and I guess iD) we fetch both the NSI data files (for the validator) and also the presets file (for the presets) - this redundancy is really unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement Actionable - add an enhancement to the source code javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

4 participants