Can't update POI data

[luigifab]

Description

I'm displaying swimming pools POI on the map. I would like to add opening hours but I can't edit it, I can only add a new POI.

Steps to reproduce

Go to 55.52213 25.08419 and display swimming pools POI. Then try to edit it.

Actual result

Can't edit POI details.

Expected result

Allow to edit the POI.

Your Environment (required)

OsmAnd Version: 4.8.6
Android/iOS version: 11
Device model: Wiko

[yuriiurshuliak]

I was unable to reproduce the issue. To try reproducing it, go to the coordinates 55.52213, 25.08419, click on the POI of the pool, select "Actions," then choose "Modify POI" and "Add Opening hours."

Please ensure that the OpenStreetMap editing plugin is enabled.

OsmAnd~ 4.9.0#3193m, released: 2024-09-16

video_2024-09-16_16-24-48.mp4

[luigifab]

yes plugin is enabled, and I tried again and I still can't edit this POI, for example next to the swimming pool there are bus stops, and I can edit them

[vshcherb]

Bug reproduced; https://www.openstreetmap.org/way/322243903.
Context menu displays correct url to way.
To fix: all nodes and ways with correct url should be editable in OSM.

[nazar-kutz]

@vshcherb The problem seems to be caused by the "no_edit=true" attribute on the poi type of this point. Maybe we should fix it in xml.

Line in XML:
<poi_type name="swimming_pool" tag="leisure" value="swimming_pool" no_edit="true" poi_additional_category="nudism,fee,access_general"/>
https://github.com/osmandapp/OsmAnd-resources/blob/master/poi/poi_types.xml#L4196

Line in code that filtering this point:
isEditable = !amenity.getType().isWiki() && poiType != null && !poiType.isNotEditableOsm();
https://github.com/osmandapp/Osmand/blob/380a20fc064c6c10f830ffa3fb34b2aeee6791d4/OsmAnd/src/net/osmand/plus/plugins/osmedit/OsmEditingPlugin.java#L347
We get "poiType.isNotEditableOsm() == true" here, and so don't show "Modify POI" action.

[vshcherb]

If internet is available we can allow edit without "predefined type" but all the tags will be loaded