Add shields for Nova Scotia scenic drives #912

quincylvania · 2023-08-03T15:21:33Z

Closes #911.

Creating a draft for sprite design feedback. Waiting for a tile refresh to review how these look on the map.

1ec5 · 2023-08-04T01:11:14Z

src/js/shield_defs.js

@@ -4201,6 +4204,33 @@ export function loadShields() {

  // Ref-specific cases. Each entry should be documented in CONTRIBUTE.md

+  shields["CA:NS:S"].overrideByRef = {
+    BdOLSD: {


Do people or publications normally refer to the routes by these initialisms? If so, let’s add an explanation to CONTRIBUTING.md, in the section where we justify other unsignposted refs.

I don't think so, I just made up the initialisms so we'd have something to key off of. I don't think we can key off the route name because I thiiiiink the name on the tile comes only from the way itself. The Merritt Parkway is the only one we do like that so far and it happens to have all way names match the parkway relation name.

This situation is kind of like the Great Lakes Circle Tour routes, but with a more items and less documentation. I imagine the problem will come up more often as we add additional networks of scenic routes.

I can add documentation for this.

For #451, the New Zealand community apparently decided to give each route a distinct network subvalue in order to avoid polluting ref with unsignposted initialisms. However, this fragmentation makes less sense when the shield designs all follow a common motif, as in this case.

I think inevitably we’ll need the tiles to contain something beyond the network=ref syntax in route_* properties. If we could go back and change the format, I would’ve suggested something like route:2:network or route_network_2, which would’ve also logically allowed for route_name_2 or even route_wikidata_2 for these tricky cases.

In the meantime, unsignposted initialisms are unfortunately a fact of life in refs in many parts of the world. If the local mappers are OK with it, then we can go along with it for now.

This situation is kind of like the Great Lakes Circle Tour routes, but with a more items and less documentation.

The Great Lakes Circle Tour routes are known by the initialisms in ref, at least informally, so it isn’t a big deal if a non-shield-capable renderer displays the ref verbatim. I’d still reach out to the local community to get their opinion on this use of ref, in case there are more established initialisms for the routes.

Regarding the choice of ref on bespoke tourist routes, don't we have overrideByName as an option? Then we would be tied to the name, which should be beyond dispute. In any case, the choice of ref value on the route relation of an obscure tourist route seems like something we can just make up using reasonable conventions and change later if the community changes their mind down the line. In short, I'd favor pushing this forward either as-is or with a name-based definition.

@ZeLonewolf overrideByName was introduced for the Kentucky parkways. I agree that it would be an ideal solution… except that the name is just the way name, not the route relation’s name. For tourist routes, the road name isn’t reliably the route relation’s name, although it is in the case of the Cabot Trail.

Yep, here's an illustrative example. Names like "Lighthouse Route" don't always appear in the data, so we're left to rely on a ref at the moment.

Yep, makes sense to me - thanks for refreshing how that works. I built the damn logic for those route_X attributes and I can't even keep it straight...

Let’s ticket out something about a route_#_name scheme in OpenMapTiles. Something similar would also help with Spain’s per-route colors in #654.

As of #1032, each feature has a route_#_name property based on the route relation. The name gets plumbed through to the shield selection code, so you should be able to specify overrideByName without worrying about the roadway carrying a different name, and the relations no longer need to be tagged with initialisms as refs.

1ec5 · 2023-08-04T01:13:59Z

icons/shield_ca_ns_s_md.svg

I wonder if a few of these shields would be more legible if we don’t need to offset them to the left but can instead have them take up more space to the top and right.

Sure, we could make the pictures slightly bigger by centering then and moving the water down. But personally I think I prefer sticking closer to the source designs. Though maybe seeing them on the map will affect this.

Yeah, we’ll see how it turns out on the map. For the Ohio River Scenic Byway in #893, I made the shield 20 pixels wide but taller than 20 pixels, avoiding whitespace on either side, in order to maximize room for the shield’s details.

The current shield for network=CA:NS:H is only 20px tall because we made it before relaxing the height guidelines for narrow shields. I think the designs introduced in this PR are good for now. If we want to enlarge them later, along with the Arterial shield, let's put that in a new issue.

ZeLonewolf · 2023-08-05T22:49:51Z

Tiles are updated!

quincylvania · 2023-08-07T19:12:56Z

In terms of size, I think the original 16x20 looks okay, perhaps too small:

I tried 18x22 to keep even numbers and it seems a bit too big:

Ultimately I'd say 17x21 is a good compromise size as long as it doesn't cause rounding/aliasing issues.

ZeLonewolf · 2023-08-07T19:19:02Z

Either the 17px or the 18px versions look pretty good to me in the screen shots. I agree that the 16px one seems slightly undersized.

…ds Scenic Drive routes

quincylvania · 2023-08-07T21:27:33Z

I standardized on 17x21 px shields. I couldn't find any signage for the Fundy Shore Scenic Drive but otherwise this is complete and ready for review. FYI there was a ref mistake for the Sunrise Trail so that shield won't show up until a new tile update goes through but you can see it in the spritesheet.

1ec5

These icons seem to hew to an 8-bit style, which happens to look great for these particular shields. I wonder if we should aim for a similar style in other shields, where we’re currently going for a very literal, realistic look and feel.

1ec5 · 2023-08-12T06:18:54Z

src/js/shield_defs.js

@@ -4201,6 +4204,33 @@ export function loadShields() {

  // Ref-specific cases. Each entry should be documented in CONTRIBUTE.md

+  shields["CA:NS:S"].overrideByRef = {
+    BdOLSD: {


This situation is kind of like the Great Lakes Circle Tour routes, but with a more items and less documentation.

The Great Lakes Circle Tour routes are known by the initialisms in ref, at least informally, so it isn’t a big deal if a non-shield-capable renderer displays the ref verbatim. I’d still reach out to the local community to get their opinion on this use of ref, in case there are more established initialisms for the routes.

ZeLonewolf · 2023-08-13T00:16:10Z

Regarding the choice of ref on bespoke tourist routes, don't we have overrideByName as an option? Then we would be tied to the name, which should be beyond dispute. In any case, the choice of ref value on the route relation of an obscure tourist route seems like something we can just make up using reasonable conventions and change later if the community changes their mind down the line. In short, I'd favor pushing this forward either as-is or with a name-based definition.

quincylvania · 2023-09-06T19:02:48Z

This is ready for review btw. The discussion kind of got lost in the code comments but I think everything's been addressed.

src/js/shield_defs.js

ZeLonewolf · 2023-09-07T11:16:50Z

src/js/shield_defs.js

+      spriteBlank: "shield_ca_ns_s_st",
+    },
+  };
+


FSSD appears to be missing:
https://www.openstreetmap.org/relation/11147926

The FSSD is documented on Wikipedia but I couldn't find any signage for it.

ZeLonewolf

Looks good pending the fix for FDLT. We can either add FSSD here or in a separate ticket.

zekefarwell · 2023-09-08T23:49:17Z

So if I understand correctly ref=BdOLSD on this route https://www.openstreetmap.org/relation/11051558 isn't a real identifier, but just made up to work around the fact that no other field from a route relation is available in OpenMapTiles? I wouldn't call myself a ground truth verifiability purist, but if that's the case this feels like a real stretch. Seems to me like it would be better to work on improving OpenMapTiles with the desire for these type of scenic route shields as motivation. I doubt these will be the last scenic routes folks will want to add.

quincylvania · 2023-09-11T21:24:31Z

So if I understand correctly ref=BdOLSD on this route https://www.openstreetmap.org/relation/11051558 isn't a real identifier, but just made up to work around the fact that no other field from a route relation is available in OpenMapTiles?

I wouldn't go so far as to say an initialism isn't a real identifier, but yes, these ref values are just unofficial workarounds (hacks).

Seems to me like it would be better to work on improving OpenMapTiles with the desire for these type of scenic route shields as motivation. I doubt these will be the last scenic routes folks will want to add.

Agreed that something cleaner upstream would be nice, that there will be more cases in the future, and that this is the kind of issue Americana could push the envelope on.

But personally I think this is a "perfect is the enemy of good" scenario and would move forward as-is. We can improve the system later. But up to y'all.

zekefarwell · 2023-09-13T02:09:13Z

personally I think this is a "perfect is the enemy of good" scenario and would move forward as-is. We can improve the system later.

I also would consider it such a scenario if this was a fully self contained project. However, we are just one part of the OSM ecosystem, and I don't think we want to be seen as a project that supports questionable tagging practices. The stakes are quite low in this case, but I think it would be best to wait for a proper solution in OpenMapTiles.

ZeLonewolf · 2023-09-13T14:00:54Z

I think openmaptiles/openmaptiles#1576 is not that far off, if the team is on board with that approach. While testing it, I did find a pretty major bug in openmaptiles that's causing a massive reduction in shields from z11 and lower. So my plan is to fix that issue and then push 1576 along. Since it's been a very long time since the last openmaptiles release, I'm led to believe we're not that far off from a proper solution for ref-less routes.

issue addressed

ZeLonewolf · 2023-09-14T14:16:46Z

Okay, the prerequisite is done.

I could use some design help in figuring out what the implementation for openmaptiles/openmaptiles#1576 should actually do to support these use cases.

ZeLonewolf · 2023-09-22T15:28:42Z

Looks like the deploy preview is hit by actions/first-interaction#10. I'll plan to do some research as to how that can be resolved.

ZeLonewolf · 2023-09-27T00:40:27Z

The CI issues have been resolved. The schema update remain unresolved.

1ec5

From my perspective, the artwork in this PR is ready to ship, so the only thing that needs to change is migrating from overrideByRef to overrideByName.

1ec5 · 2024-04-04T04:33:59Z

src/js/shield_defs.js

@@ -4201,6 +4204,33 @@ export function loadShields() {

  // Ref-specific cases. Each entry should be documented in CONTRIBUTE.md

+  shields["CA:NS:S"].overrideByRef = {
+    BdOLSD: {


As of #1032, each feature has a route_#_name property based on the route relation. The name gets plumbed through to the shield selection code, so you should be able to specify overrideByName without worrying about the roadway carrying a different name, and the relations no longer need to be tagged with initialisms as refs.

quincylvania · 2024-04-18T18:33:56Z

I've changed this to use overrideByName so I think it should be ready to go. I removed the made-up ref tags in this changeset: https://www.openstreetmap.org/changeset/150189553

claysmalley

Looks good!

ZeLonewolf · 2024-04-18T21:48:52Z

Thanks for sticking this one out! Looks awesome!

quincylvania · 2024-04-20T02:10:07Z

Thanks for running a project that improves tooling and sees things through even if it takes eight months!

quincylvania added 3 commits August 3, 2023 11:18

Add first six shields for Nova Scotia scenic drives

f47e78f

Add shield for Cabot Trail and Bras d'Or Lakes Scenic Drive

0d3a752

Add two more nova scotia scenic drive shields

5cb46f7

1ec5 reviewed Aug 4, 2023

View reviewed changes

Merge branch 'main' into ns-scenic-drives

a0c923d

quincylvania added 2 commits August 7, 2023 16:56

Convert nova scotia scenic route shields to 17x21

e70fe3b

Add shields for Kejimkujik Scenic Drive and the Digby Necks and Islan…

0a8ae07

…ds Scenic Drive routes

quincylvania marked this pull request as ready for review August 7, 2023 21:23

Fix eagle plumage

bab0b01

1ec5 reviewed Aug 12, 2023

View reviewed changes

Merge branch 'main' into ns-scenic-drives

5a998e1

claysmalley added internationalization shields labels Sep 4, 2023

Merge branch 'main' into ns-scenic-drives

adfe9b9

ZeLonewolf reviewed Sep 7, 2023

View reviewed changes

src/js/shield_defs.js Outdated Show resolved Hide resolved

ZeLonewolf reviewed Sep 7, 2023

View reviewed changes

ZeLonewolf previously requested changes Sep 7, 2023

View reviewed changes

Fix ref case (re: osm-americana#912)

0016b5a

Merge branch 'main' into ns-scenic-drives

52bba36

This was referenced Sep 9, 2023

Add route name fallback if no route ref exists openmaptiles/openmaptiles#1575

Closed

Add name fallback for cases where a route has no ref openmaptiles/openmaptiles#1576

Closed

ZeLonewolf added 3 commits September 18, 2023 21:11

Merge branch 'main' into ns-scenic-drives

d3444c6

Merge branch 'main' into ns-scenic-drives

8400293

Merge branch 'main' into ns-scenic-drives

d7e43e1

Merge branch 'main' into ns-scenic-drives

7596e3f

osm-americana deleted a comment from github-actions bot Sep 23, 2023

Merge branch 'main' into ns-scenic-drives

8e151fc

ZeLonewolf and others added 7 commits October 3, 2023 20:36

Merge branch 'main' into ns-scenic-drives

58b9091

Merge branch 'main' into ns-scenic-drives

6e4950a

Merge branch 'main' into ns-scenic-drives

a287e01

Merge branch 'main' into ns-scenic-drives

489441b

Merge branch 'main' into ns-scenic-drives

a6905dd

Merge branch 'main' into ns-scenic-drives

db8f032

Merge branch 'main' into ns-scenic-drives

f4aef35

1ec5 reviewed Apr 4, 2024

View reviewed changes

quincylvania added 2 commits April 18, 2024 14:29

Override by name instead of by ref

27abb30

Merge branch 'main' into ns-scenic-drives

7b0b0cb

claysmalley approved these changes Apr 18, 2024

View reviewed changes

ZeLonewolf merged commit 9cf4cdd into osm-americana:main Apr 18, 2024
6 checks passed

quincylvania deleted the ns-scenic-drives branch April 20, 2024 02:10

quincylvania mentioned this pull request May 1, 2024

Add Halifax bridge shields #1049

Merged

Add shields for Nova Scotia scenic drives #912

Add shields for Nova Scotia scenic drives #912

Conversation

quincylvania commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Aug 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZeLonewolf commented Aug 5, 2023

quincylvania commented Aug 7, 2023

ZeLonewolf commented Aug 7, 2023

quincylvania commented Aug 7, 2023

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZeLonewolf commented Aug 13, 2023

quincylvania commented Sep 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZeLonewolf left a comment

Choose a reason for hiding this comment

zekefarwell commented Sep 8, 2023 • edited Loading

quincylvania commented Sep 11, 2023

zekefarwell commented Sep 13, 2023

ZeLonewolf commented Sep 13, 2023 • edited Loading

ZeLonewolf commented Sep 14, 2023

ZeLonewolf commented Sep 22, 2023

ZeLonewolf commented Sep 27, 2023

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quincylvania commented Apr 18, 2024

claysmalley left a comment

Choose a reason for hiding this comment

ZeLonewolf commented Apr 18, 2024

quincylvania commented Apr 20, 2024

1ec5 Aug 4, 2023 •

edited

Loading

zekefarwell commented Sep 8, 2023 •

edited

Loading

ZeLonewolf commented Sep 13, 2023 •

edited

Loading