Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't undo on a saved game #48

Open
oskarrough opened this issue Mar 28, 2020 · 2 comments
Open

Can't undo on a saved game #48

oskarrough opened this issue Mar 28, 2020 · 2 comments
Labels
bug Something isn't working feature New feature or request low priority Consider doing other things first

Comments

@oskarrough
Copy link
Owner

The history of your turns and state, which makes it possible to undo, is stored in the ActionManager. This is not part of the game state, so you can't undo a saved game.

If we really want this to be possible, we have to move the history to the game state.
@oskarrough oskarrough added the feature New feature or request label Mar 28, 2020
@oskarrough
Copy link
Owner Author

Would be solved if we do #68

@oskarrough oskarrough added the low priority Consider doing other things first label Apr 28, 2020
@oskarrough oskarrough added the bug Something isn't working label Jun 20, 2020
@oskarrough
Copy link
Owner Author

oskarrough commented Sep 17, 2023 •
edited
Loading

I believe the saved game state somehow strips out game.past.list, which contains the queue used to undo. This is why there is nothing to undo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request low priority Consider doing other things first
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oskarrough