Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Cleaning Codebase #84

Open
saurabhbakolia opened this issue Dec 7, 2021 · 10 comments
Open

Cleaning Codebase #84

saurabhbakolia opened this issue Dec 7, 2021 · 10 comments

Comments

@saurabhbakolia
Copy link
Contributor

No description provided.

@saurabhbakolia
Copy link
Contributor Author

I want to work on cleaning codebase, please assign issue to me

@osBins
Copy link
Member

osBins commented Dec 7, 2021

Thank you for wanting to take up this issue @saurabhbakolia! Assigning it to you!

@iamrahulrnair
Copy link

Hi, may I work on this, and could u specify the description of what exactly the goal, the title seems abstract, should I modularize it?

@osBins
Copy link
Member

osBins commented Dec 14, 2021

Yes we still need work on this @iamrahulrnair! The current code base is pretty inconsistent in terms of syntax, spaces, commas, semi-colons. Do you have anything in mind?

@PrimalPimmy PrimalPimmy removed the good first issue Good for newcomers label Oct 3, 2022
@KossakowskaKarolina
Copy link
Contributor

It would also be helpful to get rid of unused old functions that are commented. And add better comments describing what existing functions do. Some of them are missing that.

@PrimalPimmy
Copy link
Member

@KossakowskaKarolina Would you like to work on this issue?

@KossakowskaKarolina
Copy link
Contributor

@PrimalPimmy Yes, I can work on this issue, just need a few details for clarification. Which files should be included in this assignment? All of the html, css and js files? What should I do with files marked as old? Is there any specification in general that I should follow? Any clues would be appreciated :)

@PrimalPimmy
Copy link
Member

PrimalPimmy commented Oct 10, 2022

@KossakowskaKarolina I merged a PR that changes a few files and folder structure. you can update your fork accordingly :3 . Also, it may be nice if any spam comments are removed in the codebase. I would suggest keep the .old files for now, I'll let you know when they are not needed.

@KossakowskaKarolina
Copy link
Contributor

@PrimalPimmy Ok, I think I got it :) Would you assign me to this?

@PrimalPimmy
Copy link
Member

Sure!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants