Skip to content

Commit 0ab4e55

Browse files
author
Michael Banin
committed
Merge remote-tracking branch 'remotes/dev/1.7' into 1.7
2 parents 21a1967 + c9c73cc commit 0ab4e55

File tree

6 files changed

+32
-2
lines changed

6 files changed

+32
-2
lines changed

src/OroCRM/Bundle/AnalyticsBundle/Tests/Functional/Model/RFMMetricStateManagerTest.php

+2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ public function tearDown()
3939
}
4040

4141
$em->flush($entities);
42+
43+
parent::tearDown();
4244
}
4345

4446
public function testResetChannelMetrics()

src/OroCRM/Bundle/CampaignBundle/Model/EmailCampaignStatisticsConnector.php

+6-2
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,12 @@ public function getStatisticsRecord(EmailCampaign $emailCampaign, $entity)
5959
->getMarketingListItem($marketingList, $entityId);
6060

6161
$manager = $this->doctrineHelper->getEntityManager($this->entityName);
62-
$statisticsRecord = $manager->getRepository($this->entityName)
63-
->findOneBy(['emailCampaign' => $emailCampaign, 'marketingListItem' => $marketingListItem]);
62+
63+
$statisticsRecord = null;
64+
if ($marketingListItem->getId() !== null) {
65+
$statisticsRecord = $manager->getRepository($this->entityName)
66+
->findOneBy(['emailCampaign' => $emailCampaign, 'marketingListItem' => $marketingListItem]);
67+
}
6468

6569
if (!$statisticsRecord) {
6670
$statisticsRecord = new EmailCampaignStatistics();

src/OroCRM/Bundle/CampaignBundle/Tests/Unit/Model/EmailCampaignStatisticsConnectorTest.php

+3
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ public function testGetStatisticsRecordExisting($existing)
6767
$marketingListItem = $this->getMockBuilder('OroCRM\Bundle\MarketingListBundle\Entity\MarketingListItem')
6868
->disableOriginalConstructor()
6969
->getMock();
70+
$marketingListItem->expects($this->any())
71+
->method('getId')
72+
->willReturn(42);
7073

7174
$this->marketingListItemConnector->expects($this->once())
7275
->method('getMarketingListItem')

src/OroCRM/Bundle/ContactBundle/Tests/Functional/ImportExportTest.php

+2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ protected function tearDown()
3434
$batchJobManager->createQuery('DELETE AkeneoBatchBundle:JobInstance')->execute();
3535
$batchJobManager->createQuery('DELETE AkeneoBatchBundle:JobExecution')->execute();
3636
$batchJobManager->createQuery('DELETE AkeneoBatchBundle:StepExecution')->execute();
37+
38+
parent::tearDown();
3739
}
3840

3941
/**

src/OroCRM/Bundle/MagentoBundle/Tests/Functional/Controller/NewsletterSubscriberControllerTest.php

+7
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
namespace OroCRM\Bundle\MagentoBundle\Tests\Functional\Controller;
44

5+
use Doctrine\ORM\EntityManager;
6+
57
use Oro\Bundle\ImportExportBundle\Job\JobExecutor;
68
use Oro\Bundle\ImportExportBundle\Job\JobResult;
79
use OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber;
@@ -66,6 +68,11 @@ protected function tearDown()
6668

6769
$this->getContainer()->set('oro_importexport.job_executor', $this->baseJobExecutor);
6870
unset($this->transport, $this->baseJobExecutor);
71+
72+
$entityManager = $this->getContainer()->get('akeneo_batch.job_repository')->getJobManager();
73+
$entityManager->getConnection()->close();
74+
75+
parent::tearDown();
6976
}
7077

7178
/**

src/OroCRM/Bundle/MagentoBundle/Tests/Functional/ImportExport/Writer/AbstractExportWriterTest.php

+12
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use Akeneo\Bundle\BatchBundle\Entity\JobExecution;
66

7+
use Doctrine\ORM\EntityManager;
78
use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
89
use OroCRM\Bundle\MagentoBundle\Provider\Transport\MagentoTransportInterface;
910

@@ -30,6 +31,9 @@ protected function setUp()
3031
protected function tearDown()
3132
{
3233
$this->dropBatchJobs();
34+
$this->closeConnections();
35+
36+
parent::tearDown();
3337
}
3438

3539
protected function dropBatchJobs()
@@ -43,6 +47,14 @@ protected function dropBatchJobs()
4347
unset($this->transport);
4448
}
4549

50+
protected function closeConnections()
51+
{
52+
$entityManager = $this->getContainer()->get('akeneo_batch.job_repository')->getJobManager();
53+
$entityManager
54+
->getConnection()
55+
->close();
56+
}
57+
4658
/**
4759
* @param string $alias
4860
* @param string $status

0 commit comments

Comments
 (0)