Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Page is showing after uploading File Successfully] #581

Open
tailm1 opened this issue Feb 22, 2019 · 2 comments
Open

[New Page is showing after uploading File Successfully] #581

tailm1 opened this issue Feb 22, 2019 · 2 comments
Labels
enhancement hard v3-feedback Feedback received on ORMA v3 release

Comments

@tailm1
Copy link

tailm1 commented Feb 22, 2019

Step 1 : Go to Upload Page
Step 2 : Upload correct file
Expected Result : a successful dialog is showing to notice new information
Actual : New page/tab is display

@geohacker geohacker added enhancement hard v3-feedback Feedback received on ORMA v3 release labels Feb 22, 2019
@geohacker
Copy link
Member

Thank you for opening the issue.

This is the legacy behavior of RLP properties upload. Particularly because the file upload is handled as POST request directly instead of an ajax request via the front-end. The RLP geometries uploads are rebuilt to allow for conflation and hence follow a job based architecture.

We'll attempt to add a success/error page but the new tab will show the current state of the upload.

cc @batpad

@batpad
Copy link
Contributor

batpad commented Feb 22, 2019

@geohacker yes, I think we would need to treat changing the architecture of the properties upload as an enhancement. However, we should definitely improve the error handling when there is invalid / no data in the uploaded file, like in this case: #567

Can make a ticket to improve error message after properties upload for invalid data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hard v3-feedback Feedback received on ORMA v3 release
Projects
None yet
Development

No branches or pull requests

3 participants