Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent crash when removing a layer #2127

Open
Grammostola opened this issue Jan 16, 2025 · 0 comments · May be fixed by #2128
Open

Silent crash when removing a layer #2127

Grammostola opened this issue Jan 16, 2025 · 0 comments · May be fixed by #2128
Labels
bug May be fixed by a core developer

Comments

@Grammostola
Copy link
Contributor

Describe the bug
Non fatal crash when removing a layer

To Reproduce
Steps to reproduce the behavior:

  • Have a removable layer in your Origo session. (removable: true prop for the layer or an added layer which normally comes with it). (promptlessRemoval: true for the layer is irrelevant.)
  • Toggle its context menu and choose to remove it. Confirm this action. Check the browser console.

Expected behavior
Layer removed from map and no crash in the console

Additional context
controls/legend/moreinfobutton tries to do
popupMenu.setVisibility(false) which fails since by the time it executes the popupMenu element's id does not reside in the document. It seems as if it disappears when the layer is removed from the map, which just happens before.

No other action of moreinfobutton (export, zoom to, more info) seems to experience the same issue.

@Flodkvist Flodkvist added the bug May be fixed by a core developer label Jan 28, 2025
@Flodkvist Flodkvist assigned MattiasSp and unassigned MattiasSp Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug May be fixed by a core developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants