auto_connect_socket = false not work when reset_connection() called #735
Closed
Kinda-kooky
started this conversation in
General
Replies: 2 comments
-
|
Yeah that makes sense. I’ll include a fix for this in the next release. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
This is fixed in the latest version of the Godot plugin, thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello, I used that (in godot plugin) : Talo.player_auth.session_manager.clear_session()
and that call : func reset_connection() -> void: from talo_socket.gd
and reset_connection call open_connection without check the value of auto_connect_socket
I think it's a good idea to move the checking from
if Talo.settings.auto_connect_socket:socket.open_connection()in
func _init_socket() -> void:in talo_manager.gdto
func open_connection():if not Talo.settings.auto_connect_socket: return # move to herevar ticket := await Talo.socket_tickets.create_ticket()var err := _socket.connect_to_url(_get_socket_url(ticket))if err != OK:print_rich("[color=yellow]Warning: Failed connecting to the Talo Socket: %s[/color]" % err)in talo_socket.gd
Beta Was this translation helpful? Give feedback.
All reactions